Conversation
…uration list/show/reconcile`
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
November 2025 (2025-11-18)❗ Breaking change release ❗ milestone
|
Hi @calvinhzy, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| storage account network-security-perimeter-configuration | sub group storage account network-security-perimeter-configuration added |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
evelyn-ys,
jsntcy,
kairu-ms and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for network security perimeter configuration commands to the Azure CLI Storage module, enabling users to list, show, and reconcile network security perimeter configurations for storage accounts.
Key Changes:
- Added three new commands:
list,show, andreconcilefor network-security-perimeter-configuration management - Implemented comprehensive test coverage with recorded test scenarios
- Integrated commands with Azure Storage Management API version 2025-01-01
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_storage_account_scenarios.py | Added test class with recorded test scenario for NSP configuration commands |
| test_storage_account_nsp.yaml | Test recording file capturing API interactions for NSP configuration operations |
| _list.py | Command implementation to list all NSP configurations for a storage account |
| _show.py | Command implementation to retrieve a specific NSP configuration |
| _reconcile.py | Command implementation to refresh NSP association information |
| init.py | Module initialization file exporting NSP configuration commands |
| __cmd_group.py | Command group registration for network-security-perimeter-configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
evelyn-ys
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Add support NSP for storage
AAZ: Azure/aaz#880
Testing Guide
History Notes
[Storage]
az storage account network-security-perimeter-configuration list/show/reconcile: Add support for network-security-perimeterThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.