{Compute} az restore-point collection: Migrate to AAZ#32295
{Compute} az restore-point collection: Migrate to AAZ#32295
az restore-point collection: Migrate to AAZ#32295Conversation
️✔️AzureCLI-FullTest
|
|
Hi @cxznmhdcxz, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| restore-point collection create | cmd restore-point collection create update parameter location: added property aaz_type=string |
||
| restore-point collection create | cmd restore-point collection create update parameter location: updated property type from custom_type to string |
||
| restore-point collection create | cmd restore-point collection create update parameter resource_group_name: added property aaz_type=string |
||
| restore-point collection create | cmd restore-point collection create update parameter resource_group_name: added property type=string |
||
| restore-point collection create | cmd restore-point collection create update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| restore-point collection create | cmd restore-point collection create update parameter restore_point_collection_name: added property aaz_type=string |
||
| restore-point collection create | cmd restore-point collection create update parameter restore_point_collection_name: added property type=string |
||
| restore-point collection create | cmd restore-point collection create update parameter restore_point_collection_name: updated property options from ['--collection-name'] to ['--collection-name', '--restore-point-collection-name'] |
||
| restore-point collection create | cmd restore-point collection create update parameter source_id: added property aaz_type=string |
||
| restore-point collection create | cmd restore-point collection create update parameter source_id: added property type=string |
||
| restore-point collection create | cmd restore-point collection create update parameter source_id: removed property required=True |
||
| restore-point collection create | cmd restore-point collection create update parameter tags: added property aaz_type=AAZDictArg |
||
| restore-point collection create | cmd restore-point collection create update parameter tags: added property type=Dict<String,String> |
||
| restore-point collection create | cmd restore-point collection create update parameter tags: updated property nargs from * to + |
||
| restore-point collection list | cmd restore-point collection list added parameter pagination_limit |
||
| restore-point collection list | cmd restore-point collection list added parameter pagination_token |
||
| restore-point collection list-all | cmd restore-point collection list-all added parameter pagination_limit |
||
| restore-point collection list-all | cmd restore-point collection list-all added parameter pagination_token |
||
| restore-point collection update | cmd restore-point collection update update parameter resource_group_name: added property aaz_type=string |
||
| restore-point collection update | cmd restore-point collection update update parameter resource_group_name: added property type=string |
||
| restore-point collection update | cmd restore-point collection update update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| restore-point collection update | cmd restore-point collection update update parameter restore_point_collection_name: added property aaz_type=string |
||
| restore-point collection update | cmd restore-point collection update update parameter restore_point_collection_name: added property id_part=name |
||
| restore-point collection update | cmd restore-point collection update update parameter restore_point_collection_name: added property type=string |
||
| restore-point collection update | cmd restore-point collection update update parameter restore_point_collection_name: updated property options from ['--collection-name'] to ['--collection-name', '--restore-point-collection-name'] |
||
| restore-point collection update | cmd restore-point collection update update parameter tags: added property aaz_type=AAZDictArg |
||
| restore-point collection update | cmd restore-point collection update update parameter tags: added property type=Dict<String,String> |
||
| restore-point collection update | cmd restore-point collection update update parameter tags: updated property nargs from * to + |
||
| restore-point collection wait | cmd restore-point collection wait update parameter expand: added property aaz_type=string |
||
| restore-point collection wait | cmd restore-point collection wait update parameter expand: added property choices=['restorePoints'] |
||
| restore-point collection wait | cmd restore-point collection wait update parameter expand: added property type=string |
||
| restore-point collection wait | cmd restore-point collection wait update parameter resource_group_name: added property aaz_type=string |
||
| restore-point collection wait | cmd restore-point collection wait update parameter resource_group_name: added property type=string |
||
| restore-point collection wait | cmd restore-point collection wait update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| restore-point collection wait | cmd restore-point collection wait update parameter restore_point_collection_name: added property aaz_type=string |
||
| restore-point collection wait | cmd restore-point collection wait update parameter restore_point_collection_name: added property id_part=name |
||
| restore-point collection wait | cmd restore-point collection wait update parameter restore_point_collection_name: added property type=string |
||
| restore-point collection wait | cmd restore-point collection wait update parameter restore_point_collection_name: updated property options from ['--collection-name'] to ['--collection-name', '--restore-point-collection-name'] |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
3ac6d8d to
d65486a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the az restore-point collection command group from the legacy SDK to the AAZ (Atomic Azure CLI) framework. The migration involves replacing custom function implementations with auto-generated AAZ commands and updating the API version from 2022-11-01 to 2024-11-01.
Key changes:
- Removed custom implementations of
restore_point_collection_create,restore_point_collection_update, and thewaitcommand - Replaced with auto-generated AAZ command implementations for
create,update,wait, andshow - Updated API version references throughout to 2024-11-01
- Added
--size Standard_B2msparameter to test VM creation commands
Reviewed Changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
custom.py |
Migrated restore_point_collection_show to use AAZ Show command instead of SDK client |
commands.py |
Removed custom command registrations and client factory references for migrated commands |
_client_factory.py |
Removed cf_restore_point_collection factory as it's no longer needed |
_params.py |
Removed parameter definitions for create and update commands (now handled by AAZ) |
_help.py |
Removed help text for migrated commands (now embedded in AAZ command definitions) |
test_vm_commands.py |
Added VM size specification to test commands for stability |
collection/*.py |
Added new auto-generated AAZ command implementations for create, update, wait, show |
collection/_list*.py |
Updated existing list commands to API version 2024-11-01 with enhanced schema support |
collection/_delete.py |
Updated API version and LRO final-state-via strategy |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Related command
az restore-point collectioncommand groupDescription
Migrate aaz
Azure/aaz#881
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.