Skip to content

{Compute} az restore-point collection: Migrate to AAZ#32295

Merged
yanzhudd merged 4 commits intoAzure:devfrom
cxznmhdcxz:restore-point-collection-migrate
Oct 27, 2025
Merged

{Compute} az restore-point collection: Migrate to AAZ#32295
yanzhudd merged 4 commits intoAzure:devfrom
cxznmhdcxz:restore-point-collection-migrate

Conversation

@cxznmhdcxz
Copy link
Copy Markdown
Member

@cxznmhdcxz cxznmhdcxz commented Oct 21, 2025

Related command

az restore-point collection command group

Description

Migrate aaz
Azure/aaz#881

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Oct 21, 2025

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.13
️✔️acs
️✔️latest
️✔️3.12
️✔️3.13
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.13
️✔️ams
️✔️latest
️✔️3.12
️✔️3.13
️✔️apim
️✔️latest
️✔️3.12
️✔️3.13
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.13
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️aro
️✔️latest
️✔️3.12
️✔️3.13
️✔️backup
️✔️latest
️✔️3.12
️✔️3.13
️✔️batch
️✔️latest
️✔️3.12
️✔️3.13
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.13
️✔️billing
️✔️latest
️✔️3.12
️✔️3.13
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.13
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.13
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.13
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.13
️✔️config
️✔️latest
️✔️3.12
️✔️3.13
️✔️configure
️✔️latest
️✔️3.12
️✔️3.13
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.13
️✔️container
️✔️latest
️✔️3.12
️✔️3.13
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.13
️✔️core
️✔️latest
️✔️3.12
️✔️3.13
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.13
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.13
️✔️dls
️✔️latest
️✔️3.12
️✔️3.13
️✔️dms
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.13
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.13
️✔️find
️✔️latest
️✔️3.12
️✔️3.13
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.13
️✔️identity
️✔️latest
️✔️3.12
️✔️3.13
️✔️iot
️✔️latest
️✔️3.12
️✔️3.13
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.13
️✔️lab
️✔️latest
️✔️3.12
️✔️3.13
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️maps
️✔️latest
️✔️3.12
️✔️3.13
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.13
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.13
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.13
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.13
️✔️network
️✔️latest
️✔️3.12
️✔️3.13
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.13
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.13
️✔️profile
️✔️latest
️✔️3.12
️✔️3.13
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.13
️✔️redis
️✔️latest
️✔️3.12
️✔️3.13
️✔️relay
️✔️latest
️✔️3.12
️✔️3.13
️✔️resource
️✔️latest
️✔️3.12
️✔️3.13
️✔️role
️✔️latest
️✔️3.12
️✔️3.13
️✔️search
️✔️latest
️✔️3.12
️✔️3.13
️✔️security
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.13
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.13
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.13
️✔️sql
️✔️latest
️✔️3.12
️✔️3.13
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.13
️✔️storage
️✔️latest
️✔️3.12
️✔️3.13
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.13
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.13
️✔️util
️✔️latest
️✔️3.12
️✔️3.13
️✔️vm
️✔️latest
️✔️3.12
️✔️3.13

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @cxznmhdcxz,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Oct 21, 2025

⚠️AzureCLI-BreakingChangeTest
⚠️vm
rule cmd_name rule_message suggest_message
⚠️ 1008 - ParaPropAdd restore-point collection create cmd restore-point collection create update parameter location: added property aaz_type=string
⚠️ 1010 - ParaPropUpdate restore-point collection create cmd restore-point collection create update parameter location: updated property type from custom_type to string
⚠️ 1008 - ParaPropAdd restore-point collection create cmd restore-point collection create update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd restore-point collection create cmd restore-point collection create update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate restore-point collection create cmd restore-point collection create update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd restore-point collection create cmd restore-point collection create update parameter restore_point_collection_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd restore-point collection create cmd restore-point collection create update parameter restore_point_collection_name: added property type=string
⚠️ 1010 - ParaPropUpdate restore-point collection create cmd restore-point collection create update parameter restore_point_collection_name: updated property options from ['--collection-name'] to ['--collection-name', '--restore-point-collection-name']
⚠️ 1008 - ParaPropAdd restore-point collection create cmd restore-point collection create update parameter source_id: added property aaz_type=string
⚠️ 1008 - ParaPropAdd restore-point collection create cmd restore-point collection create update parameter source_id: added property type=string
⚠️ 1009 - ParaPropRemove restore-point collection create cmd restore-point collection create update parameter source_id: removed property required=True
⚠️ 1008 - ParaPropAdd restore-point collection create cmd restore-point collection create update parameter tags: added property aaz_type=AAZDictArg
⚠️ 1008 - ParaPropAdd restore-point collection create cmd restore-point collection create update parameter tags: added property type=Dict<String,String>
⚠️ 1010 - ParaPropUpdate restore-point collection create cmd restore-point collection create update parameter tags: updated property nargs from * to +
⚠️ 1006 - ParaAdd restore-point collection list cmd restore-point collection list added parameter pagination_limit
⚠️ 1006 - ParaAdd restore-point collection list cmd restore-point collection list added parameter pagination_token
⚠️ 1006 - ParaAdd restore-point collection list-all cmd restore-point collection list-all added parameter pagination_limit
⚠️ 1006 - ParaAdd restore-point collection list-all cmd restore-point collection list-all added parameter pagination_token
⚠️ 1008 - ParaPropAdd restore-point collection update cmd restore-point collection update update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd restore-point collection update cmd restore-point collection update update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate restore-point collection update cmd restore-point collection update update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd restore-point collection update cmd restore-point collection update update parameter restore_point_collection_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd restore-point collection update cmd restore-point collection update update parameter restore_point_collection_name: added property id_part=name
⚠️ 1008 - ParaPropAdd restore-point collection update cmd restore-point collection update update parameter restore_point_collection_name: added property type=string
⚠️ 1010 - ParaPropUpdate restore-point collection update cmd restore-point collection update update parameter restore_point_collection_name: updated property options from ['--collection-name'] to ['--collection-name', '--restore-point-collection-name']
⚠️ 1008 - ParaPropAdd restore-point collection update cmd restore-point collection update update parameter tags: added property aaz_type=AAZDictArg
⚠️ 1008 - ParaPropAdd restore-point collection update cmd restore-point collection update update parameter tags: added property type=Dict<String,String>
⚠️ 1010 - ParaPropUpdate restore-point collection update cmd restore-point collection update update parameter tags: updated property nargs from * to +
⚠️ 1008 - ParaPropAdd restore-point collection wait cmd restore-point collection wait update parameter expand: added property aaz_type=string
⚠️ 1008 - ParaPropAdd restore-point collection wait cmd restore-point collection wait update parameter expand: added property choices=['restorePoints']
⚠️ 1008 - ParaPropAdd restore-point collection wait cmd restore-point collection wait update parameter expand: added property type=string
⚠️ 1008 - ParaPropAdd restore-point collection wait cmd restore-point collection wait update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd restore-point collection wait cmd restore-point collection wait update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate restore-point collection wait cmd restore-point collection wait update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd restore-point collection wait cmd restore-point collection wait update parameter restore_point_collection_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd restore-point collection wait cmd restore-point collection wait update parameter restore_point_collection_name: added property id_part=name
⚠️ 1008 - ParaPropAdd restore-point collection wait cmd restore-point collection wait update parameter restore_point_collection_name: added property type=string
⚠️ 1010 - ParaPropUpdate restore-point collection wait cmd restore-point collection wait update parameter restore_point_collection_name: updated property options from ['--collection-name'] to ['--collection-name', '--restore-point-collection-name']

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Oct 21, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@cxznmhdcxz cxznmhdcxz force-pushed the restore-point-collection-migrate branch from 3ac6d8d to d65486a Compare October 22, 2025 03:03
@cxznmhdcxz cxznmhdcxz marked this pull request as ready for review October 22, 2025 07:58
Copilot AI review requested due to automatic review settings October 22, 2025 07:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the az restore-point collection command group from the legacy SDK to the AAZ (Atomic Azure CLI) framework. The migration involves replacing custom function implementations with auto-generated AAZ commands and updating the API version from 2022-11-01 to 2024-11-01.

Key changes:

  • Removed custom implementations of restore_point_collection_create, restore_point_collection_update, and the wait command
  • Replaced with auto-generated AAZ command implementations for create, update, wait, and show
  • Updated API version references throughout to 2024-11-01
  • Added --size Standard_B2ms parameter to test VM creation commands

Reviewed Changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
custom.py Migrated restore_point_collection_show to use AAZ Show command instead of SDK client
commands.py Removed custom command registrations and client factory references for migrated commands
_client_factory.py Removed cf_restore_point_collection factory as it's no longer needed
_params.py Removed parameter definitions for create and update commands (now handled by AAZ)
_help.py Removed help text for migrated commands (now embedded in AAZ command definitions)
test_vm_commands.py Added VM size specification to test commands for stability
collection/*.py Added new auto-generated AAZ command implementations for create, update, wait, show
collection/_list*.py Updated existing list commands to API version 2024-11-01 with enhanced schema support
collection/_delete.py Updated API version and LRO final-state-via strategy

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yanzhudd yanzhudd merged commit 3f5d4fe into Azure:dev Oct 27, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants