Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
November 2025 (2025-11-18)❗ Breaking change release ❗ milestone
|
Hi @naga-nandyala, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vm create | cmd vm create added parameter add_proxy_agent_extension |
||
| vm update | cmd vm update added parameter add_proxy_agent_extension |
||
| vmss create | cmd vmss create added parameter add_proxy_agent_extension |
||
| vmss update | cmd vmss update added parameter add_proxy_agent_extension |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
naga-nandyala
changed the title
naga-nandyala
force-pushed
the
naga/vm_add_proxy_extension
branch
2 times, most recently
from
7315987 to
e369dd2
Compare
.gitignore
Outdated
|
|
||
| _scratch* | ||
| **/nagavm/ No newline at end of file |
There was a problem hiding this comment.
please exclude these personal configurations to the PR
| class Update(_Update): | ||
| pass | ||
|
|
There was a problem hiding this comment.
May I ask why we need these two lines?
| class Update(_Update): | |
| pass |
There was a problem hiding this comment.
removed this as we are not overrideing any logic
| vm = get_vm_to_update(cmd, resource_group_name, vm_name) | ||
|
|
||
| if add_proxy_agent_extension is not None: | ||
| from .aaz.latest.vm import Update as _Update |
There was a problem hiding this comment.
It has been imported in the line 49:
There was a problem hiding this comment.
This has been removed and i am using import at the beginning of the file
| vm = get_vm_to_update(cmd, resource_group_name, vm_name) | ||
|
|
||
| if add_proxy_agent_extension is not None: | ||
| from .aaz.latest.vm import Update as _Update |
There was a problem hiding this comment.
| from .aaz.latest.vm import Update as _Update |
| })) | ||
| vm = get_vm_to_update(cmd, resource_group_name, vm_name) | ||
|
|
||
| if add_proxy_agent_extension is not None: |
There was a problem hiding this comment.
We should not make another request for new parameters. We need to add the new parameter to the existing request body and send the request together.
There was a problem hiding this comment.
As discussed we will go with this approach to deliver the feature. we will then implement better migration for update_vm and update_vmss
| })) | ||
| vmss = get_vmss_modified(cmd, resource_group_name, name, instance_id, security_type) | ||
|
|
||
| if add_proxy_agent_extension is not None: |
There was a problem hiding this comment.
We should not make another request for new parameters. We need to add the new parameter to the existing request body and send the request together.
naga-nandyala
force-pushed
the
naga/vm_add_proxy_extension
branch
from
25cefc2 to
8d84213
Compare
naga-nandyala
force-pushed
the
naga/vm_add_proxy_extension
branch
from
4d80a6a to
1cb74ac
Compare
naga-nandyala
requested review from
jsntcy,
wangzelin007 and
zhoxing-ms
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the add_proxy_agent_extension parameter to VM and VMSS commands, allowing users to specify whether to implicitly install the ProxyAgent Extension for Linux OS. The changes also include:
- Updating API versions from 2024-11-01 to 2025-04-01 in AAZ auto-generated files
- Adding test coverage updates including skipping tests due to subscription feature requirements and changing test configurations (location, images, size)
- Various formatting and code structure improvements in AAZ files
Reviewed Changes
Copilot reviewed 5 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test_vm_commands.py | Skips disk encryption tests, updates proxy agent test location and images from Windows to Linux, adds validation for add_proxy_agent_extension parameter |
| custom.py | Adds add_proxy_agent_extension parameter handling to VM/VMSS create and update functions, imports UpdateVMSS |
| _update.py (vmss) | Updates to API version 2025-04-01, adds add_proxy_agent_extension schema support and various new properties |
| _update.py (vm) | Updates to API version 2025-04-01, adds add_proxy_agent_extension schema support and various new properties |
| _template_builder.py | Adds add_proxy_agent_extension parameter to build_vm_resource and build_vmss_resource functions |
| _params.py | Adds CLI argument definition for add_proxy_agent_extension parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if add_proxy_agent_extension is not None: | ||
|
|
||
| args = { |
There was a problem hiding this comment.
[nitpick] Empty line after the if statement reduces code readability. Remove the blank line after line 1685.
| vm = get_vm_to_update(cmd, resource_group_name, vm_name) | ||
|
|
||
| if add_proxy_agent_extension is not None: | ||
|
|
There was a problem hiding this comment.
[nitpick] Empty line after the if statement reduces code readability. Remove the blank line after line 4221.
yanzhudd
changed the title
az vm/vmss create/update: Support --add-proxy-agent-extension parameter to specify whether to implicitly install the ProxyAgent Extension
|
since this change is visible to users, please use I've already helped to refine it for this PR. |
Related command
az vm create
az vm update
az vmss create
az vmss update
Description
aaz PR: Azure/aaz#885
close: #32154
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.