Closed
Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
November 2025 (2025-11-18)❗ Breaking change release ❗ milestone
|
Hi @bebound, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Pan-Qi,
jiasli,
jsntcy,
kairu-ms,
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CI failure in the Codegen Coverage task caused by incompatible dependency versions. The issue stems from deepdiff 6.3.3 (required by the confcom extension) being incompatible with NumPy 2.0, which raises an AttributeError for the removed np.float_ attribute. The fix force-installs deepdiff==8.6.1 after extension setup to ensure compatibility with NumPy 2.0.
Key Changes:
- Added a force installation of
deepdiff==8.6.1in the CI pipeline to resolve NumPy 2.0 compatibility issues - Included a comment explaining this is a temporary workaround pending
confcomextension dependency update
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
azdev has update the deepdiff dependency to 8.6.1 at Azure/azure-cli-dev-tools#531
The Codegen Coverage fails with:
The installed deepdiff is 6.3.3 and is not compatible with numpy 2.0. By checking the index.json in extension, confcom depends on deepdiff 6.3.3: https://github.com/Azure/azure-cli-extensions/blob/de110edc4faa6464bfa82fe8dc64f46c34ad1d77/src/confcom/setup.py#L43
Force install deepdiff to fix the CI.
This PR can be reverted once
confcomupdates its dependency to the latest deepdiff.Ref: https://dev.azure.com/azclitools/public/_build/results?buildId=277501&view=logs&jobId=9345cfb0-d7b9-509c-bf97-03248f55543a&j=9345cfb0-d7b9-509c-bf97-03248f55543a&t=e1a1fdd4-b888-5743-66dc-7bbee1ce278e