{Network} az network private-endpoint dns-zone-group add: --name should be required#32303
Merged
{Network} az network private-endpoint dns-zone-group add: --name should be required#32303
az network private-endpoint dns-zone-group add: --name should be required#32303Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
November 2025 (2025-11-18)❗ Breaking change release ❗ milestone
|
Hi @necusjz, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the --name parameter required for the az network private-endpoint dns-zone-group add command to align with backend requirements. This is a breaking change that addresses an IcM incident by removing the code that previously made the parameter optional.
- Removes the line that set
nameas not required in the dns-zone-group add command - Aligns the CLI behavior with backend API requirements
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
# Conflicts: # src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_network_private_endpoint_private_dns_zone_group.yaml
necusjz
force-pushed
the
fix-dns-zone-group-pe
branch
from
9a78e08 to
8b34265
Compare
kairu-ms
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
from the IcM,
--nameshould be required, aligh with the backend.the defect introduced by #25770 2+ years ago.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.