Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the
November 2025 (2025-11-18)❗ Breaking change release ❗ milestone
|
Hi @bebound, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Pan-Qi,
jiasli,
jsntcy,
kairu-ms,
wangzelin007 and
yonzhan
This was referenced Oct 28, 2025
bebound
requested review from
Greedygre,
Juliehzl,
howang-ms,
yanzhudd and
zhoxing-ms
as code owners
bebound
modified the milestones:
November 2025 (2025-11-18)❗ Breaking change release ❗,
November 2025 (2025-11-04)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes sensitive credentials from test recording files that were accidentally committed in previous pull requests. The changes sanitize API keys and shared secrets by replacing them with placeholder values.
- Replaces actual Azure Log Analytics workspace shared keys with sanitized placeholder "abc123"
- Updates HDInsight and Container App test recordings to remove exposed credentials
- Addresses security concerns by removing sensitive data from version control
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test_hdinsight_azure_monitor_agent.yaml | Sanitized primarySharedKey and secondarySharedKey values in API response and request bodies |
| test_hdinsight_azure_monitor.yaml | Sanitized primarySharedKey and secondarySharedKey values in API response and request bodies |
| test_containerapp_up_source_with_dockerfile_e2e.yaml | Sanitized primarySharedKey and secondarySharedKey values in API response |
| test_containerapp_up_image_e2e.yaml | Sanitized primarySharedKey and secondarySharedKey values in API response |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zhoxing-ms
approved these changes
Oct 28, 2025
kairu-ms
approved these changes
Oct 28, 2025
Greedygre
approved these changes
Oct 28, 2025
wangzelin007
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove credential in recording
The credentials were introduced by
az containerapp: Update Api-version to 2025-07-01 #32179Ref: https://dev.azure.com/azclitools/public/_build/results?buildId=278862&view=logs&j=9a50307c-53e6-51fa-ddad-d8767a4a0ece&t=51a28232-c495-58b8-0a15-8a556d230675