Conversation
Signed-off-by: nshankar <nshankar@microsoft.com>
nshankar13
requested review from
FumingZhang,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @nshankar13, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks mesh disable-egress-gateway | cmd aks mesh disable-egress-gateway added |
||
| aks mesh enable-egress-gateway | cmd aks mesh enable-egress-gateway added |
microsoft-github-policy-service
bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for enabling and disabling Istio egress gateways in Azure Service Mesh (ASM). It introduces new CLI commands az aks mesh enable-egress-gateway and az aks mesh disable-egress-gateway to manage egress gateways.
Key Changes
- Added
_handle_egress_gateways_asmmethod to process egress gateway enable/disable operations - Introduced two new CLI commands for enabling and disabling egress gateways
- Added validation for egress gateway names with specific naming constraints
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
_consts.py |
Defines default egress namespace constant and maximum name length |
_params.py |
Adds command-line parameter definitions for egress gateway operations |
_validators.py |
Implements validation for egress gateway names with regex pattern matching |
_help.py |
Provides help documentation for the new commands |
commands.py |
Registers the new enable/disable egress gateway commands |
custom.py |
Implements the command handler functions for egress gateway operations |
managed_cluster_decorator.py |
Adds core logic to handle egress gateway configuration changes |
test_managed_cluster_decorator.py |
Adds unit tests for the egress gateway handler |
test_aks_commands.py |
Adds integration test for egress gateway enable/disable operations |
Comments suppressed due to low confidence (1)
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py:4860
- The newly added
_handle_egress_gateways_asmmethod is never called inupdate_azure_service_mesh_profile. This means egress gateway operations will not be processed. Add a call to_handle_egress_gateways_asmsimilar to how_handle_ingress_gateways_asmis called.
new_profile, updated_ingress_gateways_asm = self._handle_ingress_gateways_asm(new_profile)
updated |= updated_ingress_gateways_asm
new_profile, updated_pluginca_asm = self._handle_pluginca_asm(new_profile)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
Signed-off-by: nshankar <nshankar@microsoft.com>
Signed-off-by: nshankar <nshankar@microsoft.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Nov 5, 2025
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
nshankar13
changed the title
az aks mesh enable-egress-gateway: Add istio egress CLI commands
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
nshankar13
changed the title
az aks mesh enable-egress-gateway: Add istio egress CLI commandsaz aks mesh enable-egress-gateway: Add istio egress CLI commands
FumingZhang
changed the title
az aks mesh enable-egress-gateway: Add istio egress CLI commandsaz aks mesh enable-egress-gateway: Add istio egress CLI commands
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Signed-off-by: nshankar <nshankar@microsoft.com>
Signed-off-by: nshankar <nshankar@microsoft.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
approved these changes
Nov 6, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
changed the title
az aks mesh enable-egress-gateway: Add istio egress CLI commandsaz aks mesh enable-egress-gateway: Add commands to manage Azure Service Mesh egress gateway
yanzhudd
changed the title
az aks mesh enable-egress-gateway: Add commands to manage Azure Service Mesh egress gatewayaz aks mesh enable-egress-gateway/disable-egress-gateway: Add commands to manage Azure Service Mesh egress gateway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks mesh enable-egress-gatewayaz aks mesh disable-egress-gatewayDescription
Add Istio add-on egress gateway CLI commands.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.