Conversation
️✔️AzureCLI-FullTest
|
|
Hi @Jing-song, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vm application set | cmd vm application set added parameter enable_automatic_upgrade |
||
| vmss application set | cmd vmss application set added parameter enable_automatic_upgrade |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
az vm/vmss application set: Add new parameter --enable-automatic-upgrade to support enabling application automatic upgrade az vm/vmss application set: Add new parameter --enable-automatic-upgrade to support enabling application automatic upgrade
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the enable_automatic_upgrade parameter to VM and VMSS application commands, allowing users to configure automatic upgrades for Gallery Application versions.
- Added
enable_automatic_upgradeparameter tovm application setandvmss application setcommands - Implemented the parameter handling in both
set_vm_applicationsandset_vmss_applicationsfunctions - Added comprehensive test coverage for the new feature in both VM and VMSS scenarios
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/_params.py | Added CLI parameter definition for enable_automatic_upgrade with both long and short option names |
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Updated both set_vm_applications and set_vmss_applications functions to accept and apply the enable_automatic_upgrade parameter |
| src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py | Added new test case covering VM and VMSS application automatic upgrade functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py
Outdated
Show resolved
Hide resolved
D1v38om83r
left a comment
There was a problem hiding this comment.
Looks good to me.
Please update the examples in the docs to show an additional example with the newly introduced parameter
https://learn.microsoft.com/en-us/cli/azure/vmss/application?view=azure-cli-latest
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Related command
az vm/vmss application setDescription
az vm/vmss application set automatic upgrade
close #32176
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.