{NetAppFiles} Remove --endpoint-type#32395
Merged
Conversation
️✔️AzureCLI-FullTest
|
|
Hi @audunn, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jiasli,
kairu-ms and
yonzhan
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated --endpoint-type argument from the netappfiles volume create and netappfiles volume update commands, completing the breaking change window that was previously announced.
- Removes the deprecated
--endpoint-typeargument definition from both VolumeCreate and VolumeUpdate command classes - Removes the breaking change registration for the
--endpoint-typeargument
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/netappfiles/custom.py | Removes the deprecated --endpoint-type argument schema definitions from VolumeCreate and VolumeUpdate classes |
| src/azure-cli/azure/cli/command_modules/netappfiles/_breaking_change.py | Removes all breaking change registrations, leaving only the file header comments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
2
to
4
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. See License.txt in the project root for license information. | ||
| # -------------------------------------------------------------------------------------------- |
There was a problem hiding this comment.
The _breaking_change.py file now contains only header comments with no functional code. This file should be deleted entirely since it no longer serves any purpose. Empty or header-only files add unnecessary clutter to the codebase.
ReaNAiveD
modified the milestones:
December 2025 (2025-12-02),
November 2025 (2025-11-18)❗ Breaking change release ❗
kairu-ms
approved these changes
Nov 10, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
kairu-ms
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az netappfiles
Description
Removes deprecated argument --endpoint-type from az netappfiles volume create and update
Testing Guide
History Notes
[NetAppFiles] BREAKING CHANGE:
az netappfiles volume create: Remove deprecated argument--endpoint-type, this property is readOnly[NetAppFiles] BREAKING CHANGE:
az netappfiles volume update: Remove deprecated argument--endpoint-type, this property is readOnlyThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.