Skip to content

{NetAppFiles} Remove --endpoint-type #32395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 1 commit into from
Nov 10, 2025
Merged

{NetAppFiles} Remove --endpoint-type #32395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/azure-cli/azure/cli/command_modules/netappfiles/_breaking_change.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,3 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------
Comment on lines 2 to 4
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _breaking_change.py file now contains only header comments with no functional code. This file should be deleted entirely since it no longer serves any purpose. Empty or header-only files add unnecessary clutter to the codebase.

Copilot uses AI. Check for mistakes.
from azure.cli.core.breaking_change import register_argument_deprecate
register_argument_deprecate('netappfiles volume create', '--endpoint-type')
register_argument_deprecate('netappfiles volume update', '--endpoint-type')
18 changes: 0 additions & 18 deletions src/azure-cli/azure/cli/command_modules/netappfiles/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,15 +315,6 @@ def _build_arguments_schema(cls, *args, **kwargs):
minimum=50
)

# Removed in API is not needed, added here for backwards compatibility will be removed in breaking change window
args_schema.endpoint_type = AAZStrArg(
options=["--endpoint-type"],
arg_group="Replication",
help="Indicates whether the local volume is the source or destination for the Volume Replication",
nullable=True,
enum={"dst": "dst", "src": "src"},
)

# The API does only support setting Basic and Standard
args_schema.network_features.enum = AAZArgEnum({"Basic": "Basic", "Standard": "Standard"}, case_sensitive=False)

Expand Down Expand Up @@ -420,15 +411,6 @@ def _build_arguments_schema(cls, *args, **kwargs):
required=False,
)

# Removed in API is not needed, added here for backwards compatibility will be removed in breaking change window
args_schema.endpoint_type = AAZStrArg(
options=["--endpoint-type"],
arg_group="Replication",
help="Indicates whether the local volume is the source or destination for the Volume Replication",
nullable=True,
enum={"dst": "dst", "src": "src"},
)

args_schema.usage_threshold._fmt = AAZIntArgFormat(
maximum=2457600,
minimum=50
Expand Down
Loading