Conversation
️✔️AzureCLI-FullTest
|
|
Hi @nasc17, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
az postgres flexible-server create: Remove default value to --version and remove argument --create-default-databaseaz postgres flexible-server create: Remove default value to --version and remove arguments --create-default-database and --database-name
|
@yonzhan @evelyn-ys @calvinhzy please trigger test checks |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated database creation parameters from the PostgreSQL flexible server create command, making database creation a separate step. The changes align with Azure's deprecation of certain features and update test infrastructure to use current regional availability and SKU configurations.
- Removes
--database-nameand--create-default-databaseparameters from server creation - Updates default version selection to dynamically use the latest supported version instead of hardcoded version 17
- Migrates test locations from India regions to Canada regions and updates SKUs to newer versions
Reviewed Changes
Copilot reviewed 4 out of 30 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test_rdbms_flexible_commands.py | Updates test commands to remove database creation parameters, changes test locations to Canada regions, updates SKUs to newer versions, and removes validation checks for deprecated replica.capacity field |
| flexible_server_custom_postgres.py | Removes database creation logic from server create function, adds dynamic version defaulting, and updates connection string generation to use default postgres database |
| _params.py | Removes --database-name and --create-default-database parameter definitions and removes hardcoded version default |
| _breaking_change.py | Deletes file containing breaking change registration for deprecated features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
nachoalonsoportillo
left a comment
There was a problem hiding this comment.
LGTM.
Once we upgrade Python SDK to the one version supporting 2025-08-01 API, we'll have to introduce support for users to override the default database name for Elastic Clusters. At that point, we might want to introduce a new parameter called --default-database-name with a default of postgres. And the parameter should only be present when --cluster-option is set to ElasticCluster.
Let's talk more about this for planning SDK update :-) |
Related command
az postgres flexible-server createDescription
PG default version Currently 'PG17'. Remove hardcoded value being set for version, instead utilize capabilities API.
Last breaking change we removed having a database be created as default for every server. Remove the argument '--create-default-database' and stick to having customers use the 'az postgres flexible-server database' group, if they want to create any databases.
Testing Guide
Manual
History Notes
[RDBMS] BREAKING CHANGE:
az postgres flexible-server create: Remove default value to--versionand remove arguments--create-default-databaseand--database-name