Conversation
map-blasterson
requested review from
kairu-ms,
necusjz and
wangzelin007
as code owners
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR onboards Azure Maps to Private Link functionality and updates SKU/location parameters. Key changes include:
- Added private endpoint support for Maps accounts with comprehensive test coverage
- Replaced deprecated Gen1 SKU and 'global' location defaults with Gen2 SKU and location-based deployments
- Removed ability to create accounts with deprecated configurations
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test_private_endpoint_commands.py | Added new test classes and methods for Maps private link scenarios; minor formatting fixes |
| test_private_link_resource_maps.yaml | Test recording for Maps private link resource functionality |
| test_private_endpoint_connection_maps.yaml | Test recording for Maps private endpoint connection lifecycle |
| custom.py (network) | Registered Maps accounts provider for private link support |
| custom.py (maps) | Removed 'global' location constant; updated defaults to Gen2 and eastus |
| _params.py (maps) | Added location parameter to account create command |
| test_maps_commands.py | Updated tests to use Gen2 SKU and explicit eastus location |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
necusjz
changed the title
az network private-endpoint-connection: Add provider Microsoft.Maps/accounts
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32421 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@yonzhan These test failures seem unrelated to the changes in this PR. Is there anything I need to do? |
|
@map-blasterson it's related to the changes within the pr somehow https://dev.azure.com/azclitools/public/_build/results?buildId=285502&view=logs&j=bba52e8d-6558-5b45-3cd4-8081262f70b5&t=2efa5a10-4636-500d-f4e7-8b4ee0b5b0a5&l=981. recommend: if the testing scenario is complex, don't hesitate to mark it as live_only. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@map-blasterson the failed test case - https://dev.azure.com/azclitools/public/_build/results?buildId=286245&view=logs&j=c2322915-ca0d-5dd0-b94a-383d9b2059d1&t=a59ece2d-3a65-582c-2324-007952d49e0f&l=1683 seems need to re-record. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
context from @map-blasterson: the RP literally does not exist anymore for |
Related command
az maps
Description
Testing Guide
See newly added tests.
`network private-endpoint create -g {} -n {} --vnet-name {} --subnet {} --connection-name {} --private-connection-resource-id {maps-account-id}.
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.