Conversation
nachoalonsoportillo
requested review from
calvinhzy and
evelyn-ys
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
nachoalonsoportillo
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where az postgres flexible-server upgrade and az postgres flexible-server index-tuning --enabled true commands incorrectly fail with a location restriction error when the capabilities API returns OfferRestricted set to Enabled. These commands query server capabilities but should not enforce offer restrictions since they operate on existing servers.
Key Changes:
- Added a boolean parameter
is_offer_restriction_check_requiredto capability check functions to control whether offer restriction validation should be skipped - Updated
upgradeandindex-tuningcommands to passis_offer_restriction_check_required=Trueto bypass the restriction check - Modified the restriction check logic to skip validation when the parameter is True
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
_flexible_server_location_capabilities_util.py |
Added is_offer_restriction_check_required parameter to capability check functions and updated conditional logic to skip restriction checks when parameter is True |
flexible_server_custom_postgres.py |
Updated index_tuning_update to pass is_offer_restriction_check_required=True when calling capability check |
flexible_server_custom_common.py |
Updated flexible_server_version_upgrade to pass is_offer_restriction_check_required=True when calling capability check |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/rdbms/_flexible_server_location_capabilities_util.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/rdbms/_flexible_server_location_capabilities_util.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/rdbms/_flexible_server_location_capabilities_util.py
Show resolved
Hide resolved
…_capability function
nasc17
approved these changes
Dec 3, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
evelyn-ys
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server index-tuning --enabled trueDescription
az postgres flexible-server update,az postgres flexible-server create,az postgres flexible-server replica create,az postgres flexible-server index-tuning --enabled true, andaz postgres flexible-server upgrade, end up calling _postgres_parse_list_capability, which in all cases would raise error The location is restricted for provisioning of flexible servers. Please try using another region. if capabilities API returns OfferRestricted set to Enabled.For
az postgres flexible-server index-tuning --enabled trueit shouldn't do such check.Testing Guide
History Notes
{RDBMS}
az postgres flexible-server index-tuning --enabled trueshouldn't check if Capabilities API reports back that OfferRestricted isn't disabled.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.