Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an inconsistency in the az webapp config access-restriction show command where output field names were returned in a mix of camelCase and snake_case formats. The fix ensures all output is consistently in camelCase by using the SDK's .serialize() method instead of manual JSON serialization.
Key changes:
- Replaced manual JSON serialization with proper SDK
.serialize()method calls for access restriction objects - Fixed field name output to consistently use camelCase (e.g.,
ipSecurityRestrictionsDefaultActioninstead of the malformedpSecurityRestrictionsDefaultAction) - Removed unused
jsonimport
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
access_restrictions.py |
Replaced json.dumps()/json.loads() with .serialize() method calls; removed unused json import |
test_webapp_access_restriction_commands.py |
Updated test assertions to check for correct camelCase field name ipSecurityRestrictionsDefaultAction |
recordings/test_webapp_access_restriction_show.yaml |
Updated test recordings to reflect corrected command output with proper camelCase formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@yonzhan - is there a reason this was moved out of the next milestone? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Jan 30, 2026
|
@seligj95 thank you for solving this problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az webapp config access-restriction show
Description
This command returned the output in camel and snake case. Updated to always return in camel case for consistency. Resolves #32474
Testing Guide
az webapp config access-restriction show -g -n
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.