Skip to content

[Compute] az sig image-version create/update: Add warning message for Azure Compute Gallery resources from api-version 2026-03-03 #32494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanzhudd merged 13 commits into from
Jan 6, 2026
Merged

[Compute] az sig image-version create/update: Add warning message for Azure Compute Gallery resources from api-version 2026-03-03 #32494

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6602831
add warning msg to az sig image-version create/update
naga-nandyala Dec 2, 2025
41a6727
add warning msg to az sig image-version create/update
naga-nandyala Dec 4, 2025
222dbe5
add warning msg to az sig image-version create/update
naga-nandyala Dec 4, 2025
0ade229
new changes
naga-nandyala Dec 11, 2025
bfd4441
add warning msg to az sig image-version create/update
naga-nandyala Dec 2, 2025
7afedee
add warning msg to az sig image-version create/update
naga-nandyala Dec 4, 2025
5b340af
add warning msg to az sig image-version create/update
naga-nandyala Dec 4, 2025
154152f
new changes
naga-nandyala Dec 11, 2025
6a5c811
adding breaking change warning to az sig image-version create/update
Dec 11, 2025
c0e1197
adding breaking change warning to az sig image-version create/update
Dec 11, 2025
7d84fac
adding breaking change warning to az sig image-version create/update
Dec 11, 2025
7ad2672
adding breaking change warning to az sig image-version create/update
Dec 11, 2025
d5025a7
adding breaking change warning to az sig image-version create/update
Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/azure-cli/azure/cli/command_modules/vm/_breaking_change.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,27 @@
current_default='Standard_DS1_v2',
new_default='Standard_D2s_v5',
target_version=None)

register_default_value_breaking_change(command_name='sig image-version create',
arg='--end-of-life-date',
current_default=None,
new_default='6 months from publish date',
target_version=None)

register_default_value_breaking_change(command_name='sig image-version create',
arg='--block-deletion-before-end-of-life',
current_default=None,
new_default=True,
target_version=None)
Comment on lines +19 to +29
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title mentions adding warnings for both az sig image-version create and az sig image-version update, but only the create command has breaking change registrations. Add similar register_default_value_breaking_change registrations for the update command to match the PR's stated purpose, or update the PR title/description to clarify that only create is being addressed.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@naga-nandyala naga-nandyala Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have code for update as well


register_default_value_breaking_change(command_name='sig image-version update',
arg='--end-of-life-date',
current_default=None,
new_default='6 months from publish date',
target_version=None)

register_default_value_breaking_change(command_name='sig image-version update',
arg='--block-deletion-before-end-of-life',
current_default=None,
new_default=True,
target_version=None)