-
Notifications
You must be signed in to change notification settings - Fork 3.4k
{Compute} Add resiliency view command and argument #32496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
95707fc
[feat] - Added new command 'vmss get-resiliency-view'
william051200 c0923c3
[feat] - Added new argument '--resiliency-view' in 'vmss list-instances'
william051200 eed9d5e
[test] - Added test case for resiliency view
william051200 d0bebce
[style] - Edited code styling
william051200 b804114
[docs] - Added help description to new command and argument.
william051200 989cd8f
[docs] - Added help description to az vmss list-instances.
william051200 d51d25f
[docs] - Updated help description for az vmss list-instances.
william051200 5b794c0
[style] - Updated code styling.
william051200 0f741de
[fix] - Fixed custom command missing parameters
william051200 4312d2d
[test] - re-record test case
william051200 ba73224
[style] - Update code styling
william051200 da1db26
[fix] - Fixed custom command parameter
william051200 36c121c
[test] - re-record test case
william051200 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -66,6 +66,24 @@ def _output(self, *args, **kwargs): | |||||
| return result | ||||||
|
|
||||||
|
|
||||||
| from azure.cli.core.aaz import register_command | ||||||
| @register_command( | ||||||
| "vmss get-resiliency-view", | ||||||
| ) | ||||||
| class VMSSGetResiliencyView(_VMSSVMSShow): | ||||||
| """View the resiliency status of an VMSS | ||||||
| """ | ||||||
| @classmethod | ||||||
| def _build_arguments_schema(cls, *args, **kwargs): | ||||||
| args_schema = super()._build_arguments_schema(*args, **kwargs) | ||||||
| args_schema.instance_id._options = ["--instance"] | ||||||
| args_schema.vm_scale_set_name._options = ["-n", "--name"] | ||||||
| args_schema.expand._registered = False | ||||||
| return args_schema | ||||||
|
|
||||||
| def pre_operations(self): | ||||||
| self.ctx.args.expand='resiliencyView' | ||||||
|
||||||
| self.ctx.args.expand='resiliencyView' | |
| self.ctx.args.expand = 'resiliencyView' |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This import appears to be incorrect.
command_args_expressfromazdev.operations.statisticsdoesn't seem to be used anywhere in the file and shouldn't be imported fromazdev(which is a development tool package) in production code.