Conversation
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks install-cli | cmd aks install-cli added parameter gh_token |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
Member
Author
|
Queued live test to validate the change, test passed! |
FumingZhang
changed the title
az aks install-cli: Add --gh-token option to allow authentication when downloading kubeloginaz aks install-cli: Add --gh-token option to allow authentication when downloading kubelogin
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for GitHub authentication when downloading kubelogin binaries through the az aks install-cli command by introducing a new --gh-token parameter. This helps users avoid GitHub API rate limiting issues when downloading kubelogin releases.
- Adds
--gh-tokenparameter to theaks install-clicommand - Threads the token through the function call chain from
k8s_install_clitok8s_install_kubeloginto_urlopen_read - Updates HTTP request handling to include Authorization header when a token is provided
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/acs/_params.py | Adds the gh_token parameter definition with help text explaining its purpose for avoiding rate limiting |
| src/azure-cli/azure/cli/command_modules/acs/custom.py | Updates function signatures to accept and pass the gh_token parameter, and modifies _urlopen_read and _urlretrieve to include the Authorization header in HTTP requests when a token is provided |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mbifeld
previously approved these changes
Dec 16, 2025
yanzhudd
changed the title
az aks install-cli: Add --gh-token option to allow authentication when downloading kubeloginaz aks install-cli: Add --gh-token parameter to allow authentication when downloading kubelogin
Contributor
|
could you please add some tests for the newly added parameter? |
Member
Author
sure, I've added a unit test for the newly added param. |
yanzhudd
approved these changes
Dec 17, 2025
This was referenced Dec 17, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks install-cliDescription
[AKS]
az aks install-cli: Add--gh-tokenoption to allow authentication when downloading kubelogin binaries from GitHub releases, helping to prevent rate limiting. This helps resolve issue #15932Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.