Conversation
shenglol
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
ARM
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where Bicep installation messages were incorrectly printed to stdout during az deployment commands, polluting the command output. The issue occurred because recent print statements were added without checking the stdout parameter.
Key Changes:
- Introduced a helper function
output()withinensure_bicep_installation()that respects thestdoutparameter - Replaced all direct
print()calls with calls to theoutput()helper function - Simplified conditional logic for installation message output
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Please fix CI issues |
shenglol
changed the title
az deployment: Fix the issue where the Bicep installation message is printed in the command output
Contributor
Author
|
@yonzhan I fixed the PR title. Could you trigger a new CI run? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Can CI please be run again? It looks the curl command that fetches may have had a transient error. Trying to reproduce the error locally results in a successful response. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Any Update on the status of this issue? Pipelines are still broken due to json breaking output. |
|
Also experiencing this issue, can the fix please be merged? |
Member
|
@zhoxing-ms, @yonzhan - could we get a review + merge this if we're happy with the changes? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Feb 2, 2026
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
bebound
pushed a commit
that referenced
this pull request
Feb 23, 2026
…sage is printed in the command output (#32552)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az deploymentDescription
Two print statements were recently added to ensure_bicep_installation without checking whether stdout is True, which pollutes the command output.
Fixes #32549.
Testing Guide
Run any
az deploymentcommands with Bicep files.History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.