{Core} aaz: Remove requests in main thread#32824
Merged
DanielMicrosoft merged 1 commit intoAzure:devfrom Mar 9, 2026
Merged
Conversation
️✔️AzureCLI-FullTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Hi @necusjz, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
jiasli and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
necusjz
requested review from
DanielMicrosoft,
ReaNAiveD,
calvinhzy,
jsntcy and
kairu-ms
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an eager requests import from the AAZ polling implementation to reduce CLI startup/import-chain overhead (notably for -h scenarios where AAZ is imported transitively).
Changes:
- Removed the top-level
requestsimport (and related comments) fromazure.cli.core.aaz._pollerto avoid importingrequestson module import.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DanielMicrosoft
approved these changes
Mar 9, 2026
naga-nandyala
pushed a commit
that referenced
this pull request
Mar 12, 2026
nddq
pushed a commit
to nddq/azure-cli
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
in core aaz, the use of
requestscan cause performance degradation for modules such asnetworkandstorage—that is, any modules with potential import chains.the following is an experiment conducted for
az network -h:before:
after:
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.