Skip to content

{KeyVault} Update test cert encryption to AES-256-CBC #32879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notyashhh merged 3 commits into from
Mar 15, 2026
Merged

{KeyVault} Update test cert encryption to AES-256-CBC #32879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce14328
Fixed PEM Test Cert
notyashhh Mar 2, 2026
3b3dd03
Trigger CI
notyashhh Mar 2, 2026
24ef973
Merge remote-tracking branch 'origin/dev' into yash/kv-version-bump
notyashhh Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/azure-cli/azure/cli/command_modules/keyvault/tests/latest/ec521pw.pem
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
-----BEGIN EC PRIVATE KEY-----
Proc-Type: 4,ENCRYPTED
DEK-Info: DES-CBC,5A0C299B3F7E3BDD
DEK-Info: AES-256-CBC,B4F94D174FB9F1833836A3AFA1A6635B
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is empty — the "Description", "Related command", "Testing Guide", and "History Notes" sections all contain only boilerplate template text without any actual content. At minimum, the Description should explain why the PEM certificate was regenerated (i.e., the cryptography library dropped support for DES-CBC in PEM encryption, requiring migration to AES-256-CBC), and the History Notes should reflect the actual version bump changes rather than the template placeholder text.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mydomain.test.encrypted.pem file (used alongside ec521pw.pem in the same test contexts at test lines 1131–1138 and 1321–1329) still uses DES-EDE3-CBC encryption (DEK-Info: DES-EDE3-CBC,...). If the cryptography library version 46.x has also dropped support for Triple-DES (3DES) in legacy PEM encryption (as it has been on a deprecation path), this file would also fail to load, just like the original ec521pw.pem with DES-CBC. This should be verified to ensure that tests importing mydomain.test.encrypted.pem continue to pass with cryptography==46.0.5.

Copilot uses AI. Check for mistakes.

1v6YBEuF5bTH9o9cp1NPIaqW1tjFOAlwW1apXablnMeqJ8+ZIpAA4rjUg9PON/lu
p7WMzINiq6mFVoUPIIsghEXVc8KV9RfTBMcCj/F1iXMuPchSxQIahJKJDK7pGvfG
vadIH35hJDhiuJnOA/jTOYI3ltojAmHl4tRvyDDbTNyMT7ScWhYTu9rdJ0HTXpnh
arrQgvFykH8nKxlNiie/3OSrg6evNFjcHfCuFINuQUd5jv29ElyXmytR2S5dANuc
jaA3PpUfGKknPWvC6fjkMFYct6Gzw67UWbSRuESlae4=
tE4dUgy6HOWOJ6LxWZW1uI5NrkVuaMWf41rXLiKDppxQBzWhIrSsQPhfugHQ7Kud
bfOLV23zPspRkOdLyL1kFMOubVEcrbKQHeRXjH+fb5rxAsTUBY1RiJKBnMtL1TQf
eZS7WT5MscPVXrOZmRvZoQkBOgLAeVNkBRaO1br3HnDPonhbAp9n1zORaEYgWu7N
7nyRVXdBRDM0qUXIG1/81qiRVnXZDjvZDi21mPmQF3CU/rMKy2hTynzWV6Sj5GWw
XlizMlsOpqcyWliJ0JB6I/88dgx5Gik6A4Ze8KxlmQs=
-----END EC PRIVATE KEY-----
4 changes: 2 additions & 2 deletions src/azure-cli/requirements.py3.Darwin.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ certifi==2024.7.4
cffi==2.0.0
chardet==5.2.0
colorama==0.4.6
cryptography==44.0.1
cryptography==46.0.5
fabric==3.2.2
humanfriendly==10.0
idna==3.7
Expand All @@ -122,7 +122,7 @@ pycomposefile==0.0.34
PyGithub==1.55
PyJWT==2.10.1
PyNaCl==1.6.2
pyOpenSSL==25.0.0
pyOpenSSL==25.3.0
PySocks==1.7.1
python-dateutil==2.8.0
requests-oauthlib==1.2.0
Expand Down
4 changes: 2 additions & 2 deletions src/azure-cli/requirements.py3.Linux.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ certifi==2024.7.4
cffi==2.0.0
chardet==5.2.0
colorama==0.4.6
cryptography==44.0.1
cryptography==46.0.5
distro==1.6.0
fabric==3.2.2
humanfriendly==10.0
Expand All @@ -123,7 +123,7 @@ pycomposefile==0.0.34
PyGithub==1.55
PyJWT==2.10.1
PyNaCl==1.6.2
pyOpenSSL==25.0.0
pyOpenSSL==25.3.0
PySocks==1.7.1
python-dateutil==2.8.0
requests-oauthlib==1.2.0
Expand Down
4 changes: 2 additions & 2 deletions src/azure-cli/requirements.py3.windows.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ certifi==2024.7.4
cffi==2.0.0
chardet==5.2.0
colorama==0.4.6
cryptography==44.0.1
cryptography==46.0.5
fabric==3.2.2
humanfriendly==10.0
idna==3.7
Expand All @@ -123,7 +123,7 @@ PyGithub==1.55
PyJWT==2.10.1
pymsalruntime==0.20.2
PyNaCl==1.6.2
pyOpenSSL==25.0.0
pyOpenSSL==25.3.0
PySocks==1.7.1
python-dateutil==2.8.0
pywin32==310
Expand Down
Loading