Skip to content

{Core} aaz: Fix MgmtErrorFormat missing message from response #32927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
necusjz merged 2 commits into from
Mar 10, 2026
Merged

{Core} aaz: Fix MgmtErrorFormat missing message from response #32927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6e616f
fix: error missing message
necusjz Mar 6, 2026
3717fde
test: add case for error format
necusjz Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli-core/azure/cli/core/aaz/_error_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def __init__(self, json_object):
# ARM specific annotations
self.additional_info = [
TypedErrorInfo(additional_info["type"], additional_info["info"])
for additional_info in self.get_object_prop(json_object, self.ADDITIONALINFO_LABEL, [])
for additional_info in self.get_object_prop(json_object, self.ADDITIONALINFO_LABEL, []) or []
Copy link
Copy Markdown
Member

@ReaNAiveD ReaNAiveD Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ADDITIONALINFO_LABEL can be present but null, do we want additional_info to end up as None or consistently as an empty list? I don’t have a preference.

Copy link
Copy Markdown
Member Author

@necusjz necusjz Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a workaround to make it iterable in the list comprehension, previously there is an implicit error:

TypeError: 'NoneType' object is not iterable

btw, the actual logic of additional_info is

azure-cli/src/azure-cli-core/azure/cli/core/aaz/_error_format.py

Lines 142 to 145 in e6e616f

if self.additional_info:
error_str += "\nAdditional Information:"
for error_info in self.additional_info:
error_str += str(error_info)
.

]

def __str__(self):
Expand Down
21 changes: 21 additions & 0 deletions src/azure-cli-core/azure/cli/core/tests/test_aaz_error_format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# --------------------------------------------------------------------------------------------
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------
import unittest

from azure.cli.core.aaz._error_format import AAZMgmtErrorFormat


class TestMgmtErrorFormat(unittest.TestCase):
def test_additional_info_is_null(self):
response = {
"code": "BadRequest",
"message": "Test.",
"target": None,
"details": None,
"additionalInfo": None
}

error = AAZMgmtErrorFormat(response)
self.assertTrue(str(error) == '(BadRequest) Test.\nCode: BadRequest\nMessage: Test.')