{Compute} Update API version in recording file to fix CI issue#32991
{Compute} Update API version in recording file to fix CI issue#32991
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Pan-Qi,
bebound,
jiasli,
jsntcy,
kairu-ms,
wangzelin007 and
yonzhan
There was a problem hiding this comment.
Pull request overview
Updates a VM test recording to use a supported Microsoft.Network Public IP Addresses API version to resolve a CI failure caused by an invalid/future api-version in the recorded request.
Changes:
- Replace
api-version=2025-07-01withapi-version=2022-05-01in a recorded GET request URI.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -3491,7 +3491,7 @@ interactions: | |||
| User-Agent: | |||
| - AZURECLI/2.84.0 azsdk-python-core/1.38.0 Python/3.12.10 (Windows-11-10.0.26200-SP0) | |||
| method: GET | |||
There was a problem hiding this comment.
This change fixes the immediate issue, but hardcoding an older RP api-version in a recording can make future re-records inconsistent if the CLI/SDK default api-version changes again. Prefer re-recording the test with the intended/official api-version coming from the tracked SDK/cli profile (so the recording matches real traffic), or document in the test why this specific api-version is pinned (e.g., CI playback requires an existing version).
| method: GET | |
| method: GET | |
| # NOTE: The api-version in this URI is captured from live Azure traffic for this recording. | |
| # Do not change it manually; re-record the test if the CLI/SDK default api-version changes. |
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.