Skip to content

[AKS] az aks namespace update: Fix the location logic for managed namespace update operation #33054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanzhudd merged 6 commits into from
Mar 27, 2026
Merged

[AKS] az aks namespace update: Fix the location logic for managed namespace update operation #33054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
818f1e2
Fix the location logic for managed namespace update operation
xmzhao0822 Mar 26, 2026
092ae65
remove trailing space
xmzhao0822 Mar 26, 2026
fabd7a4
push a comment
xmzhao0822 Mar 26, 2026
2ede909
update the PR title
xmzhao0822 Mar 26, 2026
cb28ba9
fixed PR title
xmzhao0822 Mar 26, 2026
602cdfd
Merge remote-tracking branch 'origin/dev' into xmzhao/fix-bug-mns-upd…
xmzhao0822 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/acs/managednamespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def aks_managed_namespace_update(cmd, client, raw_parameters, headers, existedNa
namespace_name = raw_parameters.get("name")

namespace_config = updateNamespace(cmd, raw_parameters, existedNamespace)
namespace_config.location = get_cluster_location(cmd, resource_group_name, cluster_name)
namespace_config.location = existedNamespace.location

return sdk_no_wait(
no_wait,
Expand Down
45 changes: 45 additions & 0 deletions src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managednamespace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,51 @@ def test_update_managed_namespace_with_invalid_delete_policy(self, mock_get_clie
ns.aks_managed_namespace_update(cmd, None, raw_parameters, None, None, False)
self.assertIn(err, str(cm.exception))

def test_update_managed_namespace_sets_location_from_existing_namespace(self, mock_get_client):
cli_ctx = MockCLI()
cmd = MockCmd(cli_ctx)

mock_client = Mock()

existing_ns = Mock()
existing_ns.name = "test_managed_namespace"
existing_ns.location = "westus2"
existing_ns.properties.default_resource_quota.cpu_request = "300m"
existing_ns.properties.default_resource_quota.cpu_limit = "500m"
existing_ns.properties.default_resource_quota.memory_request = "1Gi"
existing_ns.properties.default_resource_quota.memory_limit = "2Gi"
existing_ns.properties.default_network_policy.ingress = "DenyAll"
existing_ns.properties.default_network_policy.egress = "AllowAll"
existing_ns.properties.adoption_policy = "Never"
existing_ns.properties.delete_policy = "Keep"

raw_parameters = {
"resource_group_name": "test_rg",
"cluster_name": "test_cluster",
"name": "test_managed_namespace",
"tags": {},
"labels": None,
"annotations": ["a=c"],
"cpu_request": None,
"cpu_limit": None,
"memory_request": None,
"memory_limit": None,
"ingress_policy": None,
"egress_policy": None,
"adoption_policy": None,
"delete_policy": None,
}

ns.aks_managed_namespace_update(cmd, mock_client, raw_parameters, None, existing_ns, False)

# The namespace that passed to begin_create_or_update should carry the existing location
call_args = mock_client.begin_create_or_update.call_args
namespace_config = call_args[0][3] # 4th positional arg
self.assertEqual(namespace_config.location, "westus2")

# No managed cluster GET should be needed for the update path
mock_get_client.assert_not_called()


if __name__ == "__main__":
unittest.main()
Loading