[Util] BREAKING CHANGE: Remove az demo#33124
Open
DanielMicrosoft wants to merge 5 commits intoAzure:devfrom
Open
[Util] BREAKING CHANGE: Remove az demo#33124DanielMicrosoft wants to merge 5 commits intoAzure:devfrom
az demo#33124DanielMicrosoft wants to merge 5 commits intoAzure:devfrom
Conversation
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
DanielMicrosoft
requested review from
ReaNAiveD,
YanaXu,
bebound,
jiasli,
naga-nandyala,
necusjz,
wangzelin007 and
yonzhan
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the hidden az demo command group and its supporting implementation from the util command module, and updates the command index so the CLI no longer advertises/loads that group.
Changes:
- Deleted demo command implementations (
demo style,demo secret-store,demo byo-access-token) fromutil/custom.py. - Removed demo command registrations, arguments, and help entries from the
utilcommand module. - Updated
commandIndex.latest.jsonto drop thedemocommand group mapping.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/util/custom.py | Removes demo-related functions/constants from the util custom command implementations. |
| src/azure-cli/azure/cli/command_modules/util/commands.py | Removes registration of demo command groups/commands. |
| src/azure-cli/azure/cli/command_modules/util/_params.py | Removes demo-related CLI argument definitions (including Theme enum usage for demo). |
| src/azure-cli/azure/cli/command_modules/util/_help.py | Removes help text entries for demo and its subcommands. |
| src/azure-cli-core/azure/cli/core/commandIndex.latest.json | Removes the demo group from the core command index mapping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DanielMicrosoft
changed the title
demo command
DanielMicrosoft
changed the title
az demo
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
DanielMicrosoft
requested review from
NoriZC,
teresaritorto and
yanzhudd
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Remove the deprecated az demo command group and its related command wiring/help/arguments from the util module.
Regenerate latest command index artifacts so generated files match source and CI latest-index validation passes.
Closes https://github.com/Azure/CLIPS/issues/8
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.