[AKS] az aks create, az aks nodepool add/update: Add option AzureContainerLinux to --os-sku parameter#33129
Conversation
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
az aks nodepool add/update: Add option AzureContainerLinux to --os-sku parametercf7563d to
2b4b0e4
Compare
There was a problem hiding this comment.
Pull request overview
Adds AzureContainerLinux as a supported value for the AKS --os-sku parameter across create and nodepool operations in the acs command module.
Changes:
- Introduces
CONST_OS_SKU_AZURECONTAINERLINUXand wires it into the--os-skuenum lists foraks create,aks nodepool add, andaks nodepool update. - Updates command help text to mention AzureContainerLinux for
--os-sku. - Adds new live-only tests covering
aks nodepool add/updatewith--os-sku AzureContainerLinux(using preview custom headers).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/acs/_consts.py |
Adds the new OS SKU constant AzureContainerLinux. |
src/azure-cli/azure/cli/command_modules/acs/_params.py |
Extends --os-sku allowed values for create/add/update to include the new constant. |
src/azure-cli/azure/cli/command_modules/acs/_help.py |
Updates help strings for --os-sku to mention AzureContainerLinux (but needs alignment with actual accepted values). |
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py |
Adds live-only tests for nodepool add/update using AzureContainerLinux. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
az aks create, az aks nodepool add/update: Add option AzureContainerLinux to --os-sku parameter
2b4b0e4 to
04e7ecc
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
04e7ecc to
9d7303f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Related command
az aks createaz aks nodepool addaz aks nodepool updateDescription
Add option AzureContainerLinux to --os-sku option for
az aks create,az aks nodepool add, andaz aks nodepool update.Testing Guide
https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=159544854&view=results
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.