{Packaging} FIX: windows pool upgraded from 2019 to 2022#33175
{Packaging} FIX: windows pool upgraded from 2019 to 2022#33175
Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
Updates Azure Pipelines Windows agent pool selection to Windows Server 2022 and aligns the local Windows MSI build script with the expected Visual Studio 2022 MSBuild install location.
Changes:
- Switch pipeline
windows_poolfrompool-windows-2019topool-windows-2022. - Update
build.cmdPATH to include Visual Studio 2022 MSBuild instead of Visual Studio 2019.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build_scripts/windows/scripts/build.cmd | Updates MSBuild location in PATH for building MSI on Windows 2022/VS2022 environments. |
| .azure-pipelines/templates/variables.yml | Moves pipeline Windows pool variable to the 2022 pool. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo. | ||
|
|
||
| set "PATH=%PATH%;%ProgramFiles%\Git\bin;%ProgramFiles%\Git\usr\bin;C:\Program Files (x86)\Git\bin;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin" | ||
| set "PATH=%PATH%;%ProgramFiles%\Git\bin;%ProgramFiles%\Git\usr\bin;C:\Program Files (x86)\Git\bin;%ProgramFiles%\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin" |
There was a problem hiding this comment.
Using %ProgramFiles% for the VS2022 MSBuild path can resolve to the 32-bit "Program Files (x86)" when the script is run from a 32-bit process, which would break MSBuild discovery (VS2022 installs under the 64-bit Program Files). Prefer using %ProgramW6432% (or vswhere to locate MSBuild) to make the PATH update reliable across environments.
| set "PATH=%PATH%;%ProgramFiles%\Git\bin;%ProgramFiles%\Git\usr\bin;C:\Program Files (x86)\Git\bin;%ProgramFiles%\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin" | |
| set "VS2022_PROGRAM_FILES=%ProgramW6432%" | |
| if "!VS2022_PROGRAM_FILES!"=="" ( | |
| set "VS2022_PROGRAM_FILES=%ProgramFiles%" | |
| ) | |
| set "PATH=%PATH%;%ProgramFiles%\Git\bin;%ProgramFiles%\Git\usr\bin;C:\Program Files (x86)\Git\bin;!VS2022_PROGRAM_FILES!\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin" |
Related command
Description
windows pool upgraded from 2019 to 2022. The Msibuild path is updated w.r.t windows pool 2022 vm.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.