Skip to content

{Packaging} FIX: windows pool upgraded to 2022 #33176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msarfraz merged 5 commits into from
Apr 15, 2026
+2 −2
Merged

{Packaging} FIX: windows pool upgraded to 2022 #33176

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c4bad7
upgraded windows pool to 2022
Apr 13, 2026
418ff28
set msbuild path
Apr 13, 2026
a51dcbd
Merge remote-tracking branch 'origin/dev' into msarfraz/upgrade-windo…
Apr 13, 2026
5a2dd6d
Merge remote-tracking branch 'origin/dev' into msarfraz/upgrade-windo…
Apr 14, 2026
5141121
Merge remote-tracking branch 'origin/dev' into msarfraz/upgrade-windo…
Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .azure-pipelines/templates/variables.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
variables:
ubuntu_pool: 'pool-ubuntu-2204'
ubuntu_multi_core_pool: 'pool-ubuntu-latest-multi-core'
windows_pool: 'pool-windows-2019'
windows_pool: 'pool-windows-2022'
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the Windows pool to 2022 can change preinstalled toolchain versions (VS workloads, Windows SDK, Python, etc.). If your pipeline relies on specific versions, consider pinning/validating required tools explicitly in the pipeline (or adding a lightweight verification step) so failures are easier to diagnose when the hosted image/tooling updates.

Copilot uses AI. Check for mistakes.
ubuntu_arm64_pool: 'pool-ubuntu-latest-arm64'
macos_pool: 'macOS-14'
macos_intel_pool: 'macOS-15'
Expand Down
2 changes: 1 addition & 1 deletion build_scripts/windows/scripts/build.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ REM See https://stackoverflow.com/a/12407934/2199657
echo build a msi installer using local cli sources and python executables. You need to have curl.exe, unzip.exe and msbuild.exe available under PATH
echo.

set "PATH=%PATH%;%ProgramFiles%\Git\bin;%ProgramFiles%\Git\usr\bin;C:\Program Files (x86)\Git\bin;C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin"
set "PATH=%PATH%;%ProgramFiles%\Git\bin;%ProgramFiles%\Git\usr\bin;C:\Program Files (x86)\Git\bin;%ProgramFiles%\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin"
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VS2022 MSBuild path uses %ProgramFiles%. In a 32-bit cmd.exe context on 64-bit Windows, %ProgramFiles% typically resolves to "C:\Program Files (x86)", but VS2022 installs under the 64-bit Program Files directory, so msbuild may not be found. Use %ProgramW6432% (or an explicit 64-bit path) for the Visual Studio 2022 segment to make the script robust regardless of process bitness.

Suggested change
set "PATH=%PATH%;%ProgramFiles%\Git\bin;%ProgramFiles%\Git\usr\bin;C:\Program Files (x86)\Git\bin;%ProgramFiles%\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin"
set "PATH=%PATH%;%ProgramFiles%\Git\bin;%ProgramFiles%\Git\usr\bin;C:\Program Files (x86)\Git\bin;%ProgramW6432%\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin"

Copilot uses AI. Check for mistakes.

Comment thread
msarfraz marked this conversation as resolved.
if "%CLI_VERSION%"=="" (
echo Please set the CLI_VERSION environment variable, e.g. 2.0.13
Expand Down
Loading