Add dummy logging#33255
Conversation
kamperiadis
requested review from
NoriZC,
teresaritorto and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @kamperiadis, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
Adds an additional user-visible progress message at the start of the App Service function app migration flow (Consumption → Flex Consumption) in the appservice command module.
Changes:
- Print a “Starting migration…” message at the beginning of
migrate_consumption_to_flex.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| print(f"Starting migration of function app '{source_name}' from Consumption to Flex Consumption...") | ||
|
|
There was a problem hiding this comment.
Avoid using print() for CLI messaging/logging here. print writes to stdout and can corrupt structured command output (e.g., -o json) for this command, which returns a resource object. Use the module logger (e.g., logger.warning for user-visible notes or logger.info for verbose-only) or another CLI output helper instead so messages go through the CLI logging pipeline and respect --only-show-errors/verbosity flags.
|
Please fix the CI issues. |
|
Please note that the code completion time for the upcoming release train is on 06/30/2026 at 02:00 UTC. If you want it to be released in this sprint, please get it ready asap and ping me in Teams directly. |
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.