{CI} Add suppression for dummy DOCKER_REGISTRY_SERVER_PASSWORD in unit tests#33279
Conversation
wangzelin007
requested review from
YanaXu,
bebound,
jiasli,
naga-nandyala and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
Pan-Qi,
jsntcy and
kairu-ms
microsoft-github-policy-service
Bot
added
Auto-Assign
There was a problem hiding this comment.
Pull request overview
Adds a CredScan suppression to unblock CI by treating a dummy DOCKER_REGISTRY_SERVER_PASSWORD value used in AppService unit tests as a known placeholder.
Changes:
- Add a new CredScan suppression entry for the placeholder value
mypasswith an AppService unit-test justification.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the suggestion! I'd prefer to keep the current placeholder-only form for two reasons:
If we want stricter scoping going forward, it might be worth a separate follow-up to align all generic-looking placeholders to file-scoped suppressions consistently. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.