Address hostile review: input validation, error handling, logging

- Trim version.txt on read (Set-ExtensionVersionVariable, Set-ExtensionVersionInBuild)
- Validate empty version.txt in Set-ExtensionVersionInBuild
- Make BuildReason/BuildId mandatory params
- Wrap Get-FileHash in try/catch
- Validate required YAML fields (namespace, displayName, description) after parsing
- Log parsed extension metadata for pipeline diagnostics
- Fix upload error handling (don't set ErrorActionPreference=Continue before upload)
- Guard CreateGitHubRelease against empty TagPrefix/TagVersion

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: rajeshkamal5050

eng/pipelines/templates/steps/publish-extension.yml

@@ -15,7 +15,7 @@ parameters:
     default: true
 
 steps:
-  - ${{ if eq(parameters.CreateGitHubRelease, true) }}:
+  - ${{ if and(eq(parameters.CreateGitHubRelease, true), ne(parameters.TagPrefix, ''), ne(parameters.TagVersion, '')) }}:
     # This step must run first because a duplicated tag means we don't need to
     # continue with any of the subsequent steps.
     - pwsh: |

eng/scripts/Set-ExtensionVersionInBuild.ps1

@@ -14,8 +14,8 @@
  #>
 param(
     [Parameter(Mandatory)] [string] $ExtensionDirectory,
-    [string] $BuildReason,
-    [string] $BuildId
+    [Parameter(Mandatory)] [string] $BuildReason,
+    [Parameter(Mandatory)] [string] $BuildId
 )
 
 Write-Host "Build reason: $BuildReason"
@@ -34,7 +34,11 @@ else {
 }
 
 $versionFile = Join-Path $ExtensionDirectory "version.txt"
-$version = Get-Content $versionFile
+$version = (Get-Content $versionFile).Trim()
+if ([string]::IsNullOrWhiteSpace($version)) {
+    Write-Error "version.txt is empty at $versionFile"
+    exit 1
+}
 $newVersion = "$version-$prereleaseCategory.$BuildId"
 
 Set-Content $versionFile -Value $newVersion

eng/scripts/Set-ExtensionVersionVariable.ps1

@@ -2,6 +2,6 @@ param(
     [string] $ExtensionDirectory 
 )
 
-$extVersion = Get-Content "$ExtensionDirectory/version.txt"
+$extVersion = (Get-Content "$ExtensionDirectory/version.txt").Trim()
 Write-Host "Extension Version: $extVersion"
 Write-Host "##vso[task.setvariable variable=EXT_VERSION;]$extVersion"

eng/scripts/Update-ExtensionDailyRegistry.ps1

@@ -73,9 +73,14 @@ $artifactFiles = @(
 foreach ($artifact in $artifactFiles) {
     $filePath = Join-Path $ReleasePath $artifact.file
     if (Test-Path $filePath) {
-        $hash = (Get-FileHash -Path $filePath -Algorithm SHA256).Hash.ToLower()
-        $checksums[$artifact.key] = $hash
-        Write-Host "Checksum $($artifact.key): $hash"
+        try {
+            $hash = (Get-FileHash -Path $filePath -Algorithm SHA256).Hash.ToLower()
+            $checksums[$artifact.key] = $hash
+            Write-Host "Checksum $($artifact.key): $hash"
+        } catch {
+            Write-Error "Failed to compute checksum for ${filePath}: $_"
+            exit 1
+        }
     } else {
         $missingArtifacts += $artifact.file
     }
@@ -126,6 +131,22 @@ foreach ($line in $extYaml -split "`n") {
 }
 if ($currentProvider) { $providers += $currentProvider }
 
+# Validate required fields were parsed
+$requiredFields = @('namespace', 'displayName', 'description')
+foreach ($field in $requiredFields) {
+    if (-not $extMeta[$field] -or $extMeta[$field] -eq '') {
+        Write-Error "Required field '$field' missing or empty in extension.yaml"
+        exit 1
+    }
+}
+
+Write-Host "Parsed extension metadata:"
+Write-Host "  namespace: $($extMeta.namespace)"
+Write-Host "  displayName: $($extMeta.displayName)"
+Write-Host "  description: $($extMeta.description)"
+Write-Host "  capabilities: $($capabilities -join ', ')"
+Write-Host "  providers: $($providers.Count)"
+
 # Load template and replace placeholders
 $template = Get-Content $TemplatePath -Raw
 $replacements = @{
@@ -217,7 +238,6 @@ Write-Host "Registry contents:"
 Get-Content $registryFile
 
 # Upload to storage
-$ErrorActionPreference = 'Continue'
 azcopy copy $registryFile $RegistryBlobPath --overwrite=true
 if ($LASTEXITCODE -ne 0) {
     Write-Error "Failed to upload registry to $RegistryBlobPath (exit code $LASTEXITCODE)"