Skip to content

[Build] Fix a potential issue with too many tags? #8741

Description

@richardpark-msft

This review feedback came out on a PR I made for the nightly builds. It's not related to the changes, but looks like it might need fixing:

The tag existence check uses gh api /repos/.../tags, which only returns the first page of tags (typically 30). If the repo has more tags, an existing tag may be missed and the pipeline will fail later when creating the release. Use the git ref endpoint to check the specific tag directly (404 => not found). (azd-code-reviewer)

#8740 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/pipelineCI/CD pipeline config (GH Actions, AzDO)bugSomething isn't workingengsysEngineering systems

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions