Promote validate-only migrations via PUT state update

Author: bhuvanshah7

azure-devops/azext_devops/dev/migration/migration.py

@@ -198,24 +198,9 @@ def _is_validate_only_succeeded(migration):
 
 
 def _promote_to_full_migration(migration_data, repository_id, organization):
-    repository_id = _resolve_repository_id(repository_id)
-    client = _get_service_client(organization)
-    url = _build_migration_url(organization, repository_id)
-
-    payload = {
-        'targetRepository': migration_data.get('targetRepository'),
-        'targetOwnerUserId': migration_data.get('targetOwnerUserId'),
-        'validateOnly': False,
-        'skipValidation': 2147483647,
-    }
-    agent_pool = migration_data.get('agentPoolName')
-    if agent_pool:
-        payload['agentPoolName'] = agent_pool
-    cutover_date = migration_data.get('scheduledCutoverDate')
-    if cutover_date:
-        payload['scheduledCutoverDate'] = cutover_date
-
-    return _send_request(client, 'POST', url, payload)
+    del migration_data
+    return _update_migration(repository_id, organization, detect=None,
+                             validate_only=False, status_requested='active')
 
 
 def _resolve_org_for_auth(organization, detect):

azure-devops/azext_devops/tests/latest/migration/test_migration.py

@@ -334,10 +334,6 @@ def test_resume_migration_promotes_validate_only_succeeded(self):
             mock_get.return_value = {
                 'status': 'succeeded',
                 'validateOnly': True,
-                'targetRepository': 'https://ghe.example.com/org/repo',
-                'targetOwnerUserId': 'testuser',
-                'agentPoolName': 'MyPool',
-                'scheduledCutoverDate': '2030-06-01T00:00:00Z',
             }
             mock_resolve.return_value = self._TEST_ORG
 
@@ -346,16 +342,12 @@ def test_resume_migration_promotes_validate_only_succeeded(self):
                              organization=self._TEST_ORG, detect=False)
 
             args = mock_send.call_args[0]
-            self.assertEqual(args[1], 'POST')
+            self.assertEqual(args[1], 'PUT')
             payload = args[3]
             self.assertFalse(payload['validateOnly'])
-            self.assertEqual(payload['skipValidation'], 2147483647)
-            self.assertEqual(payload['targetRepository'], 'https://ghe.example.com/org/repo')
-            self.assertEqual(payload['targetOwnerUserId'], 'testuser')
-            self.assertEqual(payload['agentPoolName'], 'MyPool')
-            self.assertEqual(payload['scheduledCutoverDate'], '2030-06-01T00:00:00Z')
+            self.assertEqual(payload['statusRequested'], 'active')
 
-    def test_resume_migration_promote_omits_null_optional_fields(self):
+    def test_resume_migration_promote_uses_only_state_transition_fields(self):
         with patch('azext_devops.dev.migration.migration.get_migration') as mock_get, \
              patch('azext_devops.dev.migration.migration.resolve_instance') as mock_resolve, \
              patch('azext_devops.dev.migration.migration._get_service_client') as mock_client, \
@@ -366,6 +358,9 @@ def test_resume_migration_promote_omits_null_optional_fields(self):
                 'validateOnly': True,
                 'targetRepository': 'https://ghe.example.com/org/repo',
                 'targetOwnerUserId': 'testuser',
+                'agentPoolName': 'MyPool',
+                'scheduledCutoverDate': '2030-06-01T00:00:00Z',
+                'skipValidation': 2147483647,
             }
             mock_resolve.return_value = self._TEST_ORG
 
@@ -374,8 +369,14 @@ def test_resume_migration_promote_omits_null_optional_fields(self):
                              organization=self._TEST_ORG, detect=False)
 
             payload = mock_send.call_args[0][3]
+            self.assertEqual(payload['validateOnly'], False)
+            self.assertEqual(payload['statusRequested'], 'active')
+            self.assertEqual(set(payload.keys()), {'validateOnly', 'statusRequested'})
             self.assertNotIn('agentPoolName', payload)
             self.assertNotIn('scheduledCutoverDate', payload)
+            self.assertNotIn('targetRepository', payload)
+            self.assertNotIn('targetOwnerUserId', payload)
+            self.assertNotIn('skipValidation', payload)
 
     def test_resume_succeeded_without_migration_flag_errors(self):
         with patch('azext_devops.dev.migration.migration.get_migration') as mock_get, \