Skip to content

Add ELM migrations commands#1481

Merged
v-soujanya merged 32 commits intoAzure:masterfrom
bhuvanshahMSFT:feature/elm-cli
Apr 16, 2026
Merged

Add ELM migrations commands#1481
v-soujanya merged 32 commits intoAzure:masterfrom
bhuvanshahMSFT:feature/elm-cli

Conversation

@bhuvanshahMSFT
Copy link
Copy Markdown
Contributor

@bhuvanshahMSFT bhuvanshahMSFT commented Mar 3, 2026 •
edited
Loading

What

  • Add az devops migrations command group for ELM (ADO -> GitHub Proxima) migrations.
  • Include create/status/list/pause/resume/migrate/cutover/abandon flows.
  • Add validations and formatting.
  • Add --agent-pool-name and --skip-validation to create.
  • Normalize optional create fields (trim, omit empty values).
  • Update help and unit tests for optional fields.

Why

  • Enable scripted live migration workflows via Azure DevOps CLI extension.

Testing

  • pytest azext_devops/tests/latest/migration/test_migration.py

Notes

  • Uses devfabric endpoint; --org is used for auth resolution.
  • Target repo URL must be https://microsoft.ghe.com/OrgName/RepoName.
  • Full pytest currently has unrelated failures in boards/repos auth validation tests.

@GeoffCoxMSFT
Copy link
Copy Markdown

GeoffCoxMSFT commented Mar 3, 2026

@v-anvashist @V-hmusukula @v-soujanya I had trouble finding your MSFT aliases, so please let me (gcox) know you've received this. This PR is related to a new REST API endpoint the 1ES team is adding to ADO. Could you kindly review/approve it as soon as possible as we are expecting to ship this quarter. We also need to understand how and when this repository releases. Thanks!

@bhuvanshahMSFT
Copy link
Copy Markdown
Contributor Author

bhuvanshahMSFT commented Mar 4, 2026 •
edited
Loading

@microsoft-github-policy-service agree company="Microsoft"

@bhuvanshahMSFT
Copy link
Copy Markdown
Contributor Author

bhuvanshahMSFT commented Mar 12, 2026

Summary:

  • Add optional create args agentPoolName and skipValidation with trimming/omission of empty values.
  • Update help for the new flags.
  • Add unit tests covering optional fields and trimming.

Tests:

  • pytest azext_devops/tests/latest/migration/test_migration.py

Notes:

  • Full pytest currently has existing failures in boards/repos auth validation tests (unrelated).

@bhuvanshahMSFT
Copy link
Copy Markdown
Contributor Author

bhuvanshahMSFT commented Mar 13, 2026

Style check fix:

  • Resolve flake8 E129 by simplifying the command check in azext_devops/init.py.
  • Suppress pylint W0212 for ServiceClient creds access in migration client.
  • Exclude local env/venv folders in .flake8 to avoid scanning local environments.

Local: scripts/runStyleCheck.ps1 (pylint OK, flake8 OK).

@bhuvanshahMSFT
Copy link
Copy Markdown
Contributor Author

bhuvanshahMSFT commented Mar 18, 2026

Updates in this push:

  • Merge latest master (includes macOS CI fixes).
  • Migrations now accept target repositories on github.com and any *.ghe.com host.
  • Help YAML fixed (quoted long-summary) to avoid YAML parsing error in �z devops migrations -h.
  • Added ELM migrations TSG: doc/elm_migrations_tsg.md.
  • Migration tests updated; local run: azext_devops/tests/latest/migration/test_migration.py (12 passed).

@bhuvanshahMSFT
Copy link
Copy Markdown
Contributor Author

bhuvanshahMSFT commented Mar 19, 2026

Added a command reference section to doc/migrations.md to cover the updated migration commands. Commit: 95688f4.

@bhuvanshahMSFT
Copy link
Copy Markdown
Contributor Author

bhuvanshahMSFT commented Mar 19, 2026

Updated BuildWheel task in .vscode/tasks.json to run on Windows by using python from the repo env PATH (fixes path-with-spaces issues). Commit: b51113c.

@bhuvanshahMSFT
Copy link
Copy Markdown
Contributor Author

bhuvanshahMSFT commented Mar 19, 2026

Fixed markdownlint failures by adding blank lines around lists/code blocks in doc/elm_migrations_tsg.md and correcting nested list indentation in doc/migrations.md. Commit: 9d7a0ff.

@v-soujanya
Copy link
Copy Markdown
Collaborator

v-soujanya commented Mar 20, 2026

Hi @bhuvanshahMSFT Can you fix the entire set of lint errors and make sure checks are green?

@v-soujanya
Copy link
Copy Markdown
Collaborator

v-soujanya commented Mar 21, 2026

Hi @bhuvanshahMSFT still there is a failure on lint checks. Could you please take look on this on recent run
image

@bhuvanshah7
Add ELM migrations commands
1e90bf3
@bhuvanshah7
Add migration create options
78bab25
@bhuvanshah7
Fix style checks
6c28ae0
@bhuvanshah7
Use org base for ELM migrations
a56dddd
@bhuvanshah7
Adjust BuildWheel task for Windows paths
a65cc09
@bhuvanshah7
Allow GitHub.com targets and fix help YAML
01f61fb
@bhuvanshah7
Simplify migration resume flow
de12e5b
@bhuvanshah7
Add migrations command reference
bbd23ba
@bhuvanshah7
Fix BuildWheel task on Windows
5b2e17e
@bhuvanshah7
Fix markdown lint spacing
3a17f54
@bhuvanshah7
Fix markdown lint and flake8 indentation errors
e2af141
@bhuvanshah7
Add --include-inactive help example and unit test for list migrations
667c47e
@bhuvanshah7
Fix convert_date_string_to_iso8601 returning datetime instead of stri…
1315885 
…ng for tz-aware inputs
@bhuvanshah7
Apply dev feedback: remove URL validation, fix validate-only default,…
11fba39 
… unify flag naming, generic skip-validation help
@bhuvanshah7
Update ELM migrations TSG with current params, codedev.ms troubleshoo…
010c80e 
…ting, output formats
@bhuvanshah7
TSG: add complete command/param reference, list step, cutover cancel,…
8dc649c 
… all optional params
@bhuvanshah7
TSG: restructure as end-to-end guide with setup, lifecycle, walkthrou…
f714a52 
…gh, and scenarios
@bhuvanshah7
TSG: add fresh-user onboarding, concrete examples, status interpretat…
3922888 
…ion table, shell note
@bhuvanshah7
docs: update TSG to use ADO org URL instead of separate ELM service URL
b17ee0e
@bhuvanshah7
docs: update migrations.md to use ADO org URL instead of ELM service URL
30708f0
@bhuvanshah7
Fix statusRequested field handling in pause/resume and update help URLs
70a3dda
@bhuvanshah7
Make --agent-pool optional; server assigns default pool
0e468eb 
- Remove required check for --agent-pool in create_migration
- Conditionally include agentPoolName in payload only when provided
- Server auto-assigns EnterpriseLiveMigrationPool when omitted
- Update tests: replace required-agent-pool tests with optional behavior tests
@bhuvanshah7
Update migration changes and tests
e28df3a
@bhuvanshah7
Promote validate-only migrations via PUT state update
1c3c38b
@bhuvanshah7
Improve migrations CLI UX validations and guidance
4433f87
@bhuvanshah7
Expand ELM migration docs and TSG guidance
5cba73e
@bhuvanshah7
Support skip-validation names and integer values
acb79a0
@bhuvanshah7
Add project filter support for migrations list
d50de9a
@bhuvanshah7
Fix flake8 W503 in migration state check
f7b4943
@bhuvanshah7
Fix markdown lint spacing and list formatting
eb4d3a2
@bhuvanshah7
Fix remaining markdown lint issues in migration docs
6bb3221
bhaveshbhati
bhaveshbhati reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown

@bhaveshbhati bhaveshbhati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review comments.

Comment thread azure-devops/azext_devops/dev/common/arguments.py
d = d.replace(tzinfo=tzlocal())
d = d.isoformat()
return d
return d.isoformat()
Copy link
Copy Markdown

@bhaveshbhati bhaveshbhati Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this change ?

@v-soujanya v-soujanya merged commit 75ab14d into Azure:master Apr 16, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v-soujanya v-soujanya v-soujanya approved these changes

@v-anvashist v-anvashist Awaiting requested review from v-anvashist v-anvashist is a code owner

@V-hmusukula V-hmusukula Awaiting requested review from V-hmusukula

@mishrarish mishrarish Awaiting requested review from mishrarish mishrarish is a code owner

+1 more reviewer

@bhaveshbhati bhaveshbhati bhaveshbhati left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bhuvanshahMSFT @GeoffCoxMSFT @v-soujanya @bhaveshbhati @bhuvanshah7