Skip to content

Commit 304f4ef

Browse files
committed
clean up for v2 afd design
1 parent 0be5437 commit 304f4ef

4 files changed

Lines changed: 16 additions & 19 deletions

File tree

azure/functions/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,4 +110,4 @@
110110
'McpPropertyType'
111111
)
112112

113-
__version__ = '1.25.0b3.dev2'
113+
__version__ = '1.25.0b3.dev3'

azure/functions/decorators/durable_functions.py

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -20,30 +20,26 @@ def get_durable_package():
2020
If neither package is installed, we return None.
2121
"""
2222
_logger.info("Attempting to import Durable Functions package.")
23-
using_legacy = False
24-
using_durable_task = False
2523
global df
2624
if df:
2725
_logger.info("Durable Functions package already loaded. DF: %s", df)
2826
return df
2927

28+
# Check for azure-functions-durable package
3029
try:
31-
import durabletask # noqa
32-
using_durable_task = True
33-
_logger.info("`durabletask` package found.")
34-
except ImportError:
35-
_logger.info("`durabletask` package not found.")
36-
pass
37-
try:
38-
import azure.durable_functions as durable_functions # noqa
30+
import azure.durable_functions as durable_functions # noqa
3931
_logger.info("`azure.durable_functions` package found.")
4032
except ImportError:
4133
_logger.info("`azure.durable_functions` package not found.")
42-
pass
43-
44-
if not using_durable_task and not using_legacy:
4534
return None
4635

36+
# Check version of azure-functions-durable package
37+
try:
38+
if hasattr(durable_functions, 'version') and durable_functions.version.startswith("2."):
39+
_logger.info("Using `azure.durable_functions` v2.x package.")
40+
except Exception:
41+
_logger.info("Using `azure.durable_functions` v1.x package.")
42+
4743
df = durable_functions
4844

49-
return durable_functions
45+
return df

azure/functions/decorators/function_app.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,8 +358,8 @@ def _get_durable_blueprint(self):
358358
else:
359359
error_message = \
360360
"Attempted to use a Durable Functions decorator, " \
361-
"but the `durabletask-azurefunctions` SDK package could not be " \
362-
"found. Please install `durabletask-azurefunctions` to use " \
361+
"but the `azure-functions-durable` SDK package could not be " \
362+
"found. Please install `azure-functions-durable` to use " \
363363
"Durable Functions."
364364
raise Exception(error_message)
365365

azure/functions/durable_functions.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -387,17 +387,18 @@ def register_durable_converters():
387387
meta._ConverterMeta._bindings.pop("activityTrigger", None)
388388
meta._ConverterMeta._bindings.pop("durableClient", None)
389389

390-
if pkg.__name__ == "azure.durable_functions":
390+
if not hasattr(pkg, 'version'):
391391
_logger.info("Registering Legacy Durable Functions converters.")
392392
meta._ConverterMeta._bindings["orchestrationTrigger"] = LegacyOrchestrationTriggerConverter
393393
meta._ConverterMeta._bindings["entityTrigger"] = LegacyEnitityTriggerConverter
394394
meta._ConverterMeta._bindings["activityTrigger"] = LegacyActivityTriggerConverter
395395
meta._ConverterMeta._bindings["durableClient"] = LegacyDurableClientConverter
396-
else:
396+
elif hasattr(pkg, 'version') and pkg.version.startswith("2."):
397397
_logger.info("Registering Durable Task Durable Functions converters.")
398398
meta._ConverterMeta._bindings["orchestrationTrigger"] = OrchestrationTriggerConverter
399399
meta._ConverterMeta._bindings["entityTrigger"] = EnitityTriggerConverter
400400
meta._ConverterMeta._bindings["activityTrigger"] = ActivityTriggerConverter
401401
meta._ConverterMeta._bindings["durableClient"] = DurableClientConverter
402+
402403
_logger.info("Durable Functions converters registered.")
403404
_logger.info("Current bindings after registration: %s", meta._ConverterMeta._bindings)

0 commit comments

Comments
 (0)