feat: Add adu tls support#846
Draft
ketkimnaik wants to merge 9 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Device Update (ADU) deployment support for selecting the protocol used when devices download update payloads, defaulting to secure-by-default HTTPS while allowing HTTP for compatibility. It updates the ADU dataplane SDK surface to include the new downloadSecurity field/enum and adds an integration test round-trip for both values.
Changes:
- Add
--download-security {https|http}toaz iot du device deployment createand plumb it through to the dataplaneDeploymentmodel. - Update the generated ADU dataplane models/enums to include
DownloadSecurityandDeployment.downloadSecurity. - Add integration test coverage asserting
downloadSecurityround-trips for bothhttpsandhttp, and update the SDK default api-version to2026-06-01.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| azext_iot/tests/deviceupdate/test_adu_update_int.py | Adds integration assertions for downloadSecurity on create/show for both https and http. |
| azext_iot/sdk/deviceupdate/dataplane/models/_models_py3.py | Adds download_security field mapping to the generated Deployment model. |
| azext_iot/sdk/deviceupdate/dataplane/models/_device_update_client_enums.py | Introduces generated DownloadSecurity enum (https/http). |
| azext_iot/sdk/deviceupdate/dataplane/models/init.py | Exports DownloadSecurity from the models package. |
| azext_iot/sdk/deviceupdate/dataplane/_configuration.py | Updates default dataplane api_version to 2026-06-01. |
| azext_iot/deviceupdate/params.py | Adds CLI argument definition for --download-security using an enum arg type. |
| azext_iot/deviceupdate/common.py | Adds CLI-side enum ADUDownloadSecurityType. |
| azext_iot/deviceupdate/commands_deployment.py | Wires download_security into deployment creation request model. |
| azext_iot/deviceupdate/_help.py | Adds a help example demonstrating --download-security http. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…utoRest Use AutoRest 3.9.2 + @autorest/python@5.19.0 against: specification/deviceupdate/data-plane/Microsoft.DeviceUpdate/stable/2026-06-01/deviceupdate.json Key changes from 2022-10-01: - api_version updated to 2026-06-01 throughout all operations - Added DownloadSecurity enum (https/http) - Added download_security field to Deployment model
HangyiWang
reviewed
Jun 26, 2026
HangyiWang
reviewed
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --download-security (TLS) support for ADU deployments
New --download-security {https|http} parameter on az iot du device deployment create, letting customers choose the protocol for update payload downloads. Aligns with Azure secure-by-default (TLS/https); http remains available for compatibility.
Surfaces downloadSecurity on deployment output, so deployment show/create clearly indicate which protocol is used for content downloads — improving visibility for mixed environments.
Adopts the 2026-06-01 ADU dataplane API (new DownloadSecurity enum + Deployment.downloadSecurity field), with help examples and integration-test coverage asserting both https and http round-trip.
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
Thank you for contributing to the IoT extension!
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Intent for Production
devormainare of production grade. Corollary to this, any merged contributions to these branches may be deployed in a public release at any given time. By checking this box, you agree and commit to the expected production quality of code.Basic expectations
pytest <project root> -vv. Please provide evidence in the form of a screenshot showing a succesful run of tests locally OR a link to a test pipeline that has been run against the change-set..pylintrcand.flake8rules? Look at the CI scripts for example usage.Azure IoT CLI maintainers reserve the right to enforce any of the outlined expectations.
A PR is considered ready for review when all basic expectations have been met (or do not apply).