[Compute] Adding Scheduledevents to VM and VMSS by haagha · Pull Request #29123 · Azure/azure-powershell

haagha · 2026-01-30T16:09:53Z

Description

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1511

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

…zVM, and Update-AzVmss cmdlets - Introduced `-ScheduledEventsApiVersion` to specify the API version for Scheduled Events configuration. - Added `-EnableAllInstancesDown` to auto-approve Scheduled Events when all instances are down. - Updated related help documentation for cmdlets to reflect new parameters. - Enhanced handling of Scheduled Events policy in the cmdlet implementations.

… scheduledevents

azure-client-tools-bot-prd · 2026-01-30T16:09:56Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

Pull request overview

Adds Scheduled Events configuration support to Az.Compute VM/VMSS (and Availability Set) cmdlets by introducing two new parameters that populate ScheduledEventsPolicy in the corresponding ARM payloads.

Changes:

Added -ScheduledEventsApiVersion and -EnableAllInstancesDown parameters to VM/VMSS/Availability Set create/update cmdlets and wired them into request models.
Updated generated/help markdown to document the new parameters.
Added new scenario tests (and one new recording) intended to validate the behavior.

Reviewed changes

Copilot reviewed 23 out of 25 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
src/Compute/Compute/help/Update-AzVmss.md	Documents new Scheduled Events parameters for `Update-AzVmss` (and adds `-ProgressAction` entry).
src/Compute/Compute/help/Update-AzVM.md	Documents new Scheduled Events parameters for `Update-AzVM` (and adds `-ProgressAction` entry).
src/Compute/Compute/help/Update-AzAvailabilitySet.md	Documents new Scheduled Events parameters for `Update-AzAvailabilitySet` (and adds `-ProgressAction` entry).
src/Compute/Compute/help/New-AzVmss.md	Documents new Scheduled Events parameters for `New-AzVmss` and updates syntax block.
src/Compute/Compute/help/New-AzVM.md	Documents new Scheduled Events parameters for `New-AzVM` and updates syntax block.
src/Compute/Compute/VirtualMachine/Operation/UpdateAzureVMCommand.cs	Adds parameters and populates `ScheduledEventsPolicy` for VM update calls.
src/Compute/Compute/VirtualMachine/Operation/NewAzureVMCommand.cs	Adds parameters and passes Scheduled Events inputs through strategy-based VM creation; also forwards `ScheduledEventsPolicy` from `PSVirtualMachine` to the SDK model.
src/Compute/Compute/Strategies/ComputeRp/VirtualMachineStrategy.cs	Extends strategy VM config builder to construct `ScheduledEventsPolicy` during VM creation.
src/Compute/Compute/Strategies/ComputeRp/VirtualMachineScaleSetStrategy.cs	Extends strategy VMSS config builder to construct `ScheduledEventsPolicy` during VMSS creation.
src/Compute/Compute/Models/PSVirtualMachine.cs	Adds `ScheduledEventsPolicy` property to the PowerShell VM model.
src/Compute/Compute/Manual/VirtualMachineScaleSetCreateOrUpdateMethod.cs	Adds Scheduled Events parameters to VMSS create cmdlet path and passes them into strategy config.
src/Compute/Compute/Manual/PSVirtualMachineScaleSet.cs	Adds `ScheduledEventsPolicy` property to the PowerShell VMSS model.
src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetUpdateMethod.cs	Adds Scheduled Events parameters to `Update-AzVmss` and applies them only in PUT path (not PATCH).
src/Compute/Compute/ChangeLog.md	Adds an Upcoming Release note about the new parameters.
src/Compute/Compute/AvailabilitySets/UpdateAzureAvailabilitySetCommand.cs	Adds parameters and populates `ScheduledEventsPolicy` for availability set updates.
src/Compute/Compute.Test/SessionRecords/Microsoft.Azure.Commands.Compute.Test.ScenarioTests.AvailabilitySetTests/TestAvailabilitySetScheduledEventsPolicy.json	Adds a recording for the new availability set Scheduled Events scenario.
src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.ps1	Adds a VM Scheduled Events scenario test script.
src/Compute/Compute.Test/ScenarioTests/VirtualMachineTests.cs	Registers the new VM Scheduled Events scenario test for check-in runs.
src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.ps1	Adds a VMSS Scheduled Events scenario test script.
src/Compute/Compute.Test/ScenarioTests/VirtualMachineScaleSetTests.cs	Registers the new VMSS Scheduled Events scenario test for check-in runs.
src/Compute/Compute.Test/ScenarioTests/StrategiesVirtualMachineTests.ps1	Adds a strategy-based `New-AzVM` SimpleParameterSet Scheduled Events scenario test script.
src/Compute/Compute.Test/ScenarioTests/StrategiesVirtualMachineTests.cs	Registers the new strategy-based Scheduled Events scenario test for check-in runs.
src/Compute/Compute.Test/ScenarioTests/AvailabilitySetTests.ps1	Adds an availability set Scheduled Events scenario test script.
src/Compute/Compute.Test/ScenarioTests/AvailabilitySetTests.cs	Registers the new availability set Scheduled Events scenario test for check-in runs.

Comments suppressed due to low confidence (1)

src/Compute/Compute/help/New-AzVmss.md:651

The -HighSpeedInterconnectPlacement parameter help no longer lists its accepted values (e.g., None/Trunk). Other cmdlets in this module include an "Accepted values:" line for constrained strings; please restore that here to avoid losing important guidance.

### -HighSpeedInterconnectPlacement
Specifies the high speed interconnect placement for the virtual machine scale set.

```yaml
Type: System.String
Parameter Sets: (All)
Aliases:

Required: False
Position: Named
Default value: None
Accept pipeline input: True (ByPropertyName)
Accept wildcard characters: False

</details>

Copilot

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 3 comments.

isra-fel

Hi, please see the comments inline, and resolve the conflicts. THanks

# Conflicts: # src/Compute/Compute/ChangeLog.md

… -EnableAllInstancesDown across VM, VMSS, and AvailabilitySet Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 22 out of 26 changed files in this pull request and generated 9 comments.

thomas-temby · 2026-06-23T03:38:32Z

Hi @haagha,

Can you please action the comments by copilot, or justify why the comment is invalid.

…on and drop ProgressAction help placeholder Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…Update-AzAvailabilitySet PUT path Address Copilot review: copy ScheduledEventsPolicy from the input object so piping (e.g. Get-AzVM | Update-AzVM) without re-specifying the parameters no longer clears an existing configuration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 22 out of 26 changed files in this pull request and generated 6 comments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…mss help Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

haagha · 2026-06-25T13:01:51Z

@thomas-temby all comments have been addressed

Copilot

Pull request overview

Copilot reviewed 22 out of 26 changed files in this pull request and generated 1 comment.

Resolve conflicts by keeping both ScheduledEvents and VMSS Lifecycle Hooks additive changes across ChangeLog, PSVirtualMachineScaleSet, Strategies tests, and help docs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…e for VM - Tighten Test-SimpleNewVmScheduledEventsPolicy to assert the policy is returned on create (API now echoes scheduledEventsPolicy at api-version 2025-11-01), mirroring the VMSS test. - Extend the test to cover Update-AzVM by toggling EnableAllInstancesDown and asserting the change is persisted. - Re-record the session against live Azure. - Trim implementation-detail bullets from the Compute ChangeLog per review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 22 out of 26 changed files in this pull request and generated 1 comment.

+        [Parameter(
+            Mandatory = false,
+            ValueFromPipelineByPropertyName = true,
+            HelpMessage = "Specifies the api-version to determine which Scheduled Events configuration schema version will be delivered. Format: YYYY-MM-DD. For available API versions, see https://learn.microsoft.com/rest/api/compute/scheduled-events.")]
+        public string ScheduledEventsApiVersion { get; set; }


Haider Agha added 3 commits January 28, 2026 17:33

Refactor code structure for improved readability and maintainability

f8ffe8d

Merge branch 'main' of https://github.com/Azure/azure-powershell into…

f1f0c77

… scheduledevents

Copilot AI review requested due to automatic review settings January 30, 2026 16:09

haagha requested review from DanielMicrosoft, NoriZC, Pan-Qi, VeryEarly, YanaXu, audreyttt, dolauli, isra-fel, notyashhh, ookoka, vidai-msft and wyunchi-ms as code owners January 30, 2026 16:09

Copilot started reviewing on behalf of haagha January 30, 2026 16:12 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

isra-fel added needs-review Compute labels Feb 3, 2026

isra-fel added this to the Az 15.4.0 (03/03/2026) milestone Feb 3, 2026

isra-fel self-assigned this Feb 3, 2026

Haider Agha added 2 commits February 3, 2026 11:46

removing duplicate test

6853532

remove duplicate test

0528bae

Copilot AI review requested due to automatic review settings February 3, 2026 16:48

Copilot started reviewing on behalf of haagha February 3, 2026 16:50 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

Comment thread src/Compute/Compute/help/New-AzVmss.md Outdated

Comment thread src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetUpdateMethod.cs

Comment thread src/Compute/Compute.Test/ScenarioTests/AvailabilitySetTests.ps1 Outdated

removing extra test

5a156ca

isra-fel reviewed Feb 18, 2026

View reviewed changes

Comment thread src/Compute/Compute/help/New-AzVM.md

Comment thread src/Compute/Compute/help/Update-AzAvailabilitySet.md Outdated

teresaritorto added this to the Az 16.1.0 (07/07/2026) milestone Jun 2, 2026

Haider Agha and others added 2 commits June 17, 2026 13:44

Merge remote-tracking branch 'origin/main' into scheduledevents

a948084

# Conflicts: # src/Compute/Compute/ChangeLog.md

[Compute] Standardize ScheduledEvents all-instances-down parameter to…

4fa6088

… -EnableAllInstancesDown across VM, VMSS, and AvailabilitySet Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 17, 2026 18:49

Copilot started reviewing on behalf of haagha June 17, 2026 18:50 View session

Copilot AI reviewed Jun 17, 2026

View reviewed changes

Haider Agha and others added 2 commits June 24, 2026 14:02

[Compute] Address Copilot review: guard empty ScheduledEventsApiVersi…

40b5b8b

…on and drop ProgressAction help placeholder Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 25, 2026 12:11

Copilot started reviewing on behalf of haagha June 25, 2026 12:11 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Haider Agha and others added 2 commits June 25, 2026 08:48

Add YYYY-MM-DD validation to ScheduledEventsApiVersion parameter

4dbb404

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Re-add accepted values for -HighSpeedInterconnectPlacement in New-AzV…

8ab4ba3

…mss help Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 25, 2026 12:59

Copilot started reviewing on behalf of haagha June 25, 2026 12:59 View session

haagha requested review from thomas-temby and removed request for YanaXu and dolauli June 25, 2026 13:02

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetUpdateMethod.cs

Merge branch 'main' into scheduledevents

cd173dd

Resolve conflicts by keeping both ScheduledEvents and VMSS Lifecycle Hooks additive changes across ChangeLog, PSVirtualMachineScaleSet, Strategies tests, and help docs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

audreyttt reviewed Jun 26, 2026

View reviewed changes

Comment thread src/Compute/Compute.Test/ScenarioTests/StrategiesVirtualMachineTests.ps1 Outdated

Comment thread src/Compute/Compute.Test/ScenarioTests/StrategiesVirtualMachineTests.ps1

Comment thread src/Compute/Compute/ChangeLog.md Outdated

Copilot AI review requested due to automatic review settings June 26, 2026 19:00

Copilot started reviewing on behalf of haagha June 26, 2026 19:01 View session

audreyttt approved these changes Jun 26, 2026

View reviewed changes

Copilot AI reviewed Jun 26, 2026

View reviewed changes

thomas-temby approved these changes Jun 29, 2026

View reviewed changes

thomas-temby merged commit eb510d7 into main Jun 29, 2026
13 checks passed

Uh oh!

Conversation

haagha commented Jan 30, 2026

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd Bot commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isra-fel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thomas-temby commented Jun 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

haagha commented Jun 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone