Add RoutingConfiguration support for RouteServerPeer and VirtualNetwo…#29605
Add RoutingConfiguration support for RouteServerPeer and VirtualNetwo…#29605irramtir wants to merge 3 commits into
Conversation
…rkGatewayConnection - Added RoutingConfiguration, VirtualHubVnetConnection, and VirtualHubVnetConnectionId parameters to Add-AzRouteServerPeer and Update-AzRouteServerPeer - Added RoutingConfiguration parameter to New-AzVirtualNetworkGatewayConnection and Set-AzVirtualNetworkGatewayConnection - Updated PSBgpConnection, PSRouteServerPeer, PSRouteServer, PSVirtualNetworkGatewayConnection models - Added scenario tests for RouteServerPeer and VirtualNetworkGatewayConnection with RoutingConfiguration - Updated help documentation for all affected cmdlets
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for a new optional RoutingConfiguration (inbound/outbound route maps) across Route Server peers and Virtual Network Gateway connections, plus optional hub VNet connection association for Route Server peers.
Changes:
- Added
RoutingConfigurationtoNew/Set-AzVirtualNetworkGatewayConnectionand surfaced it in models/help. - Added
RoutingConfiguration,VirtualHubVnetConnection, andVirtualHubVnetConnectionIdtoAdd/Update-AzRouteServerPeerand surfaced it in models/help. - Added scenario coverage for
RoutingConfigurationon Virtual Network Gateway connections and Route Server peers.
Reviewed changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Network/Network/help/Update-AzRouteServerPeer.md | Documents new routing/hub VNet connection parameters for updating peers |
| src/Network/Network/help/Add-AzRouteServerPeer.md | Documents new routing/hub VNet connection parameters for creating peers |
| src/Network/Network/help/New-AzVirtualNetworkGatewayConnection.md | Documents new -RoutingConfiguration on create |
| src/Network/Network/help/Set-AzVirtualNetworkGatewayConnection.md | Documents new -RoutingConfiguration on update |
| src/Network/Network/VirtualNetworkGatewayConnection/NewAzureVirtualNetworkGatewayConnectionCommand.cs | Adds RoutingConfiguration parameter and assignment on creation |
| src/Network/Network/VirtualNetworkGatewayConnection/UpdateAzureVirtualNetworkGatewayConnectionCommand.cs | Adds RoutingConfiguration parameter and assignment on update |
| src/Network/Network/RouteServerPeer/AddAzureRMRouteServerPeerCommand.cs | Adds routing configuration + hub VNet connection association for peer create |
| src/Network/Network/RouteServerPeer/UpdateAzureRMRouteServerPeerCommand.cs | Adds routing configuration + hub VNet connection association for peer update |
| src/Network/Network/Models/PSVirtualNetworkGatewayConnection.cs | Adds model property + text formatting helper for RoutingConfiguration |
| src/Network/Network/Generated/Models/PSRouteServerPeer.cs | Adds routing configuration + hub VNet connection exposure in peer model |
| src/Network/Network/Generated/Models/PSRouteServer.cs | Plumbs new properties into route server peerings projection |
| src/Network/Network/Generated/Models/PSBgpConnection.cs | Adds routing configuration + text formatting helper |
| src/Network/Network/ChangeLog.md | Changelog entries for new parameters |
| src/Network/Network.Test/ScenarioTests/VirtualNetworkGatewayConnectionTests.ps1 | Adds scenario test for routing configuration on gateway connection |
| src/Network/Network.Test/ScenarioTests/VirtualNetworkGatewayConnectionTests.cs | Adds xUnit entry point for new gateway connection scenario |
| src/Network/Network.Test/ScenarioTests/RouteServerTests.ps1 | Adds scenario test for routing configuration on route server peer |
| src/Network/Network.Test/ScenarioTests/RouteServerTests.cs | Adds xUnit entry point for new route server peer scenario |
|
Hi @irramtir, please fix CI errors. |
…mutual exclusion validation, bounded polling loops
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@irramtir please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Description
Add optional parameter routingConfiguration to virtualNEtworkGatewayConnectio, BgpConnection and RouteSErverPeer which is a derived resource from bgpConnection
Swagger change: Azure/azure-rest-api-specs#42409
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.