Skip to content

[data[protection] fix help docs to reflect latest retention rules change#29652

Open
IannGeorges wants to merge 1 commit into
Azure:mainfrom
MabOneSdk:users/ianna/dupretrulesfix2
Open

[data[protection] fix help docs to reflect latest retention rules change#29652
IannGeorges wants to merge 1 commit into
Azure:mainfrom
MabOneSdk:users/ianna/dupretrulesfix2

Conversation

@IannGeorges
Copy link
Copy Markdown
Member

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings May 20, 2026 14:38
@azure-client-tools-bot-prd
Copy link
Copy Markdown

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates DataProtection cmdlet help to reflect the latest AzureBlob retention rule behavior (OperationalStore rule now added alongside the existing Vault rule), and removes an outdated operational-only policy example.

Changes:

  • Removed the operational-only AzureBlob policy example from generated and source help markdown.
  • Updated the hybrid AzureBlob example to add Default_OperationalStore without overwriting the existing Default (Vault) rule, and clarified the accompanying narrative.
  • Simplified -Name parameter help text in Edit-AzDataProtectionPolicyRetentionRuleClientObject.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/DataProtection/DataProtection/help/New-AzDataProtectionBackupPolicy.md Aligns user-facing help example(s) and narrative with current AzureBlob retention rule semantics.
src/DataProtection/DataProtection.Autorest/docs/New-AzDataProtectionBackupPolicy.md Mirrors the same help updates in the AutoRest-generated docs output.
src/DataProtection/DataProtection.Autorest/custom/Cmdlets/Policy/Edit-AzDataProtectionPolicyRetentionRuleClientObject.ps1 Updates parameter help messages related to retention rule naming/removal constraints.

The fourth command overwrites the vault lifecycle with operational store lifecycle.
The last command creates the operational store policy.

### Example 4: Create a vaulted policy for AzureBlob
The fourth command overwrites the vault lifecycle with operational store lifecycle.
The last command creates the operational store policy.

### Example 4: Create a vaulted policy for AzureBlob
[Parameter(ParameterSetName='AddRetention',Mandatory, HelpMessage='Retention Rule Name. Note: Default_OperationalStore is applicable to AzureBlob only and is reserved for OperationalStore lifecycles; on AzureBlob, -Name Default is reserved for VaultStore lifecycles.')]
[Parameter(ParameterSetName='RemoveRetention',Mandatory, HelpMessage='Retention Rule Name. Note: Default and Default_OperationalStore are default retention rules and cannot be removed.')]
[Parameter(ParameterSetName='AddRetention',Mandatory, HelpMessage='Retention Rule Name.')]
[Parameter(ParameterSetName='RemoveRetention',Mandatory, HelpMessage='Retention Rule Name. Note: Default retention rules cannot be removed.')]
@VeryEarly
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Next we create FirstOfDay, FirstOfWeek tag criteria and update the policy.
The last command creates the policy.

### Example 4: Create a operational policy for AzureBlob
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the examples to files under "examples" and run "build-module.ps1". The files under "docs" are auto generated.

@YanaXu
Copy link
Copy Markdown
Contributor

YanaXu commented May 21, 2026

Hi @IannGeorges,
Please fix the PR title.
The ChangeLog file path is src/DataProtection/DataProtection/ChangeLog.md. Please add a line right below Upcoming Release using the past tense to describe the purpose of this PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants