Update Azure.Identity to 1.21.0#29654
Draft
isra-fel wants to merge 5 commits into
Draft
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates shared/authentication-related dependencies used across Azure PowerShell (primarily those shipped/loaded via Az.Accounts) and applies small code adjustments in several modules to resolve type/namespace ambiguities introduced by the dependency bumps.
Changes:
- Bumped shared/runtime dependency set (Azure.Core/Azure.Identity/MSAL/System.* and related transitive deps) and refreshed the Az.Accounts conditional assembly loading inventory.
- Updated several modules’ code to fully-qualify
Identitymodel types to avoid ambiguous references. - Added a repo agent guide for the standard shared-dependency update workflow and documented the dependency changes in Az.Accounts’ changelog.
Reviewed changes
Copilot reviewed 29 out of 60 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/Common.Netcore.Dependencies.targets | Updates compile-time Azure.Core reference version. |
| src/lib/manifest.json | Updates the shared dependency manifest (versions, TFMs, adds new transitive deps). |
| src/Accounts/AssemblyLoading/ConditionalAssemblyProvider.cs | Regenerates/updates the shared assembly load list/versions for Az.Accounts. |
| src/lib/cgmanifest.json | Updates component governance manifest to match updated shared dependencies. |
| src/Accounts/Authentication/Authentication.csproj | Bumps Azure.Identity/Azure.Identity.Broker/MSAL compile-time references. |
| src/Accounts/Authenticators/Factories/AzureCredentialFactory.cs | Updates Managed Identity credential construction and suppresses obsolete API warnings. |
| src/Accounts/Authenticators/SilentAuthenticator.cs | Adds scoped obsolete-warning suppressions around SharedTokenCache credential options. |
| src/Accounts/Authenticators/UsernamePasswordAuthenticator.cs | Adds scoped obsolete-warning suppression (with a TODO to migrate). |
| src/Accounts/Accounts/ChangeLog.md | Adds Upcoming Release notes for dependency upgrades. |
| .github/agents/dependencyUpdate.agent.md | Adds guidance for contributors on updating shared dependencies via AzDev. |
| src/Storage/Storage.Management/StorageAccount/SetAzureStorageAccount.cs | Fully qualifies Storage Identity usage to resolve conflicts. |
| src/Storage/Storage.Management/StorageAccount/NewAzureStorageAccount.cs | Fully qualifies Storage Identity usage to resolve conflicts. |
| src/Storage/Storage.Management/Models/PSStorageAccount.cs | Fully qualifies Storage Identity property type. |
| src/Search/Search/SearchService/SetSearchServiceCommand.cs | Resolves Identity ambiguity via namespace alias/cast. |
| src/Search/Search/SearchService/NewSearchServiceCommand.cs | Resolves Identity ambiguity via namespace alias/cast. |
| src/Search/Search/Models/PSIdentity.cs | Updates explicit conversion operators to use a namespace alias for Identity. |
| src/Resources/Resources/Resources.csproj | Updates Microsoft.Extensions.DependencyInjection.Abstractions reference. |
| src/Resources/ResourceManager/SdkModels/Resources/PSResource.cs | Fully qualifies ResourceManager Identity to resolve conflicts. |
| src/RecoveryServices/RecoveryServices/RecoveryServices.csproj | Updates System.Security.Cryptography.Cng package reference. |
| src/KeyVault/KeyVault/KeyVault.csproj | Updates System.Security.Cryptography.Cng package reference. |
| src/IotHub/IotHub/IotHub.csproj | Updates Microsoft.Extensions.DependencyInjection.Abstractions reference. |
| src/DataFactory/DataFactoryV1/DataFactoryV1.csproj | Updates System.IO.FileSystem.AccessControl package reference. |
| src/OperationalInsights/OperationalInsights/Models/PSIdentity.cs | Fully qualifies OperationalInsights Identity to resolve conflicts. |
| src/CognitiveServices/CognitiveServices/Models/PSCognitiveServicesAccount.cs | Fully qualifies CognitiveServices Identity property type. |
| src/CognitiveServices/CognitiveServices/CognitiveServicesAccount/SetAzureCognitiveServicesAccount.cs | Fully qualifies CognitiveServices Identity instantiation. |
| src/CognitiveServices/CognitiveServices/CognitiveServicesAccount/NewAzureCognitiveServicesAccount.cs | Fully qualifies CognitiveServices Identity instantiation. |
| src/Automation/Automation/Model/AutomationAccount.cs | Fully qualifies Automation Identity property type. |
| src/Automation/Automation/Common/AutomationPSClient.cs | Uses an alias to fully qualify Automation Identity construction. |
| src/ArtifactSigning/ArtifactSigning/ArtifactSigning.csproj | Updates System.Formats.Asn1 package reference. |
Comments suppressed due to low confidence (1)
src/Accounts/Accounts/ChangeLog.md:27
- In the Upcoming Release notes, “MSAL” is introduced without expansion. Per changelog guidance, please expand less-obvious acronyms on first use in the release section (e.g., “MSAL (Microsoft Authentication Library)”).
* Upgraded `System.Text.Json` dependency from 8.0.6 to 10.0.3.
* Upgraded MSAL dependencies (`Microsoft.Identity.Client`, `Microsoft.Identity.Client.Extensions.Msal`, `Microsoft.Identity.Client.Broker`) from 4.83.1 to 4.84.0.
|
|
||
| ## Upcoming Release | ||
| * Upgraded `Azure.Core` dependency from 1.50.0 to 1.56.0. | ||
| * Upgraded `Azure.Identity` dependency from 1.17.2 to 1.21.0. |
Comment on lines
14
to
+17
| <ItemGroup> | ||
| <PackageReference Include="Azure.Identity" Version="1.13.0" /> | ||
| <PackageReference Include="Azure.Identity.Broker" Version="1.1.0" /> | ||
| <PackageReference Include="Microsoft.Identity.Client" Version="4.82.1" /> | ||
| <PackageReference Include="Microsoft.Identity.Client.Extensions.Msal" Version="4.82.1" /> | ||
| <PackageReference Include="Microsoft.Identity.Client.Broker" Version="4.82.1" /> | ||
| <PackageReference Include="Azure.Identity" Version="1.21.0" /> | ||
| <PackageReference Include="Azure.Identity.Broker" Version="1.6.0" /> | ||
| <PackageReference Include="Microsoft.Identity.Client" Version="4.84.0" /> |
Comment on lines
54
to
57
| var requestContext = new TokenRequestContext(scopes, isCaeEnabled: true); | ||
| #pragma warning disable CS0618 // SharedTokenCacheCredentialOptions is obsolete; TODO: migrate to replacement API | ||
| UsernamePasswordCredential passwordCredential; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.