Restore azuredeploy.json for ADLS backup sample (fork-PR canary for #14769)#14770
Conversation
- main.bicep: trailing newline (no semantic change), classifies PR as deploy-affecting per preflight rules - metadata.json: adds testResult.deployments with correlationId and deploymentName from a verified deployment (templateHash 13943866408139100773, executionStatus Succeeded) - This is a canary PR from a fork to verify the end-to-end fork contributor path through commit-generated-on-merge (testing Azure#14769)
|
/validate |
🤖 Quickstart Sample SummarySample Summary
Resources Deployed
Security Findings
Key Parameters
Notes for Reviewers
Files Touched
Generated by the quickstart summarizer agent (v2 — agentic + MSDO security) · triggered by /validate |
Why
Two purposes:
Restore
azuredeploy.jsonforbackup-create-adls-storage-account-enable-protection. This sample was merged in September/November 2025 (PRs Add template for Azure Data Lake vaulted backup #14616, ADLS vaulted backup uses BlobBackupDatasourceParameters instead of AdlsBlobBackupDatasourceParameters #14630 #14631) before the new pipeline contract existed. It has noazuredeploy.jsonon master and notestResultin itsmetadata.json, so its "Deploy to Azure" button is broken today.Verify the fork-PR end-to-end path through
commit-generated-on-merge(the path discussed in commit-generated-on-merge skipped for fork PRs leaves master without azuredeploy.json #14769). This PR is fromalex-frankel/azure-quickstart-templates(a fork), so on merge we'll learn empirically whethercommit-generated-on-mergefires for fork PRs or skips them per the same-repo guard.What's in this PR
main.bicep: trailing newline only (no semantic change). Classifies the PR as deploy-affecting forselected-pipeline's preflight.metadata.json: addstestResult.deploymentswithcorrelationIdanddeploymentNamefrom a verified deployment (templateHash13943866408139100773,executionStatusSucceeded).azuredeploy.jsonis intentionally not committed — letting CI compile and commit it viacommit-generated-on-mergeis the whole point of the canary.Deployment details
correlationId:070c2fcc-1d41-4289-84f9-f8ae46cf981bdeploymentName:adls-backup-canary-20260513-142256southcentralusb7d5acb, so version match isn't required)armprodeus(verified via direct Kusto probe)Expected behavior
validate-samples-resultspasses (early gate: template + metadata both updated in diff)./validate.selected-pipelinecompilesmain.bicep→azuredeploy.json(file is absent from PR diff because it's absent from master), readsgeneratorVersionfrom ADX, recompiles with matching Bicep, hashes, compares — should match.commit-generated-on-mergefires for the fork PR (per @ouldsid's read) → master getsazuredeploy.jsonand commit-generated-on-merge skipped for fork PRs leaves master without azuredeploy.json #14769 closes as "won't fix / misread."commit-generated-on-mergeskips due to the same-repo gate (per the YAML I read) → master is left withoutazuredeploy.jsonand commit-generated-on-merge skipped for fork PRs leaves master without azuredeploy.json #14769 stays open with concrete evidence.Either outcome is informative.
Related
cc @ouldsid