Skip to content

Remove obsolete ports#14735

Open
zoran-rilak-msft wants to merge 1 commit intoAzure:masterfrom
zoran-rilak-msft:sqlmi-staleports-3
Open

Remove obsolete ports#14735
zoran-rilak-msft wants to merge 1 commit intoAzure:masterfrom
zoran-rilak-msft:sqlmi-staleports-3

Conversation

@zoran-rilak-msft
Copy link
Copy Markdown
Contributor

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

@alex-frankel
Copy link
Copy Markdown
Contributor

Thanks for the cleanup. A couple of things to look at:

1. AzQuickStarts-MAC failure (legacy pipeline). I haven't dug into the build log — could you take a look at the linked ADO build and share what you find? Likely worth resolving before merge.

2. New testResult metadata. The contribution guide was recently updated to ask contributors to deploy the template and capture the deployment results (correlationId, deploymentName) in metadata.json under testResult.deployments. It's not yet strictly required for existing-sample edits like these, but please add it if you can — it'll become the standard going forward and helps the new ADX-based validation flow. Details and format: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md#testresult

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants