Remove redundant key-vault-create-rbac sample#14763
Merged
alex-frankel merged 1 commit intoMay 13, 2026
Merged
Conversation
This was referenced May 13, 2026
Contributor
Author
|
@alex-frankel — thanks again for your patience and the helpful feedback on the previous round of PRs (#14739, #14740, #14741, #14742). This one is a pure folder deletion (no template change to deploy), so no |
key-vault-create now uses Azure RBAC (enableRbacAuthorization: true) by default, making this separate sample redundant. No external samples in the repo reference key-vault-create-rbac. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
msmbaldwin
force-pushed
the
akv-deprecate-key-vault-create-rbac
branch
from
8d1d8ca to
a19a209
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deletes the
quickstarts/microsoft.keyvault/key-vault-create-rbacsample.Why
This sample was originally added to demonstrate a vault with Azure RBAC authorization (rather than the legacy access-policy model). The sibling
key-vault-createsample was recently updated (#14704) to useenableRbacAuthorization: trueby default, sokey-vault-create-rbacis now functionally identical tokey-vault-createand just adds noise. Anyone landing on the index looking for an RBAC-enabled vault sample should land onkey-vault-create.No external samples in this repo reference
key-vault-create-rbac; the only references were inside the sample's own README.Validation
Pure folder deletion — no template changes to deploy. The validate-samples.yml early metadata gate triggers on modified template files, not on deletions, so no
testResultupdate is required.