Skip to content

Added required field to the metadata existing deploymentscript sample…#14771

Merged
ouldsid merged 2 commits into
Azure:masterfrom
ouldsid:master
May 15, 2026
Merged

Added required field to the metadata existing deploymentscript sample…#14771
ouldsid merged 2 commits into
Azure:masterfrom
ouldsid:master

Conversation

@ouldsid
Copy link
Copy Markdown
Member

@ouldsid ouldsid commented May 15, 2026

… and removed the computed json deployment file to test the new pipeline

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

… and removed the computed json deployment file to test the new pipeline
@ouldsid
Copy link
Copy Markdown
Member Author

ouldsid commented May 15, 2026

/validate

@azure-quickstarts azure-quickstarts removed the metadata violations metadata violations during PR label May 15, 2026
@ouldsid
Copy link
Copy Markdown
Member Author

ouldsid commented May 15, 2026

/validate

@github-actions
Copy link
Copy Markdown

🤖 Quickstart Sample Summary

Sample Summary

  • This sample demonstrates best practices for passing complex inputs (boolean, integer, string, array, and object), reading outputs, and retrieving logs from an Azure CLI Deployment Script resource using an ARM/Bicep template.

  • It deploys an Azure Deployment Script that executes a bash script which consumes these inputs and produces outputs.

  • The sample also shows how to read logs generated by the deployment script.

  • To deploy, you can use the "Deploy to Azure" button in the README or use command-line deployment with the included templates and parameters files.

Resources Deployed

  • Microsoft.Resources/deploymentScripts defined in main.bicep as a resource named myScript. This resource runs the Azure CLI script with supplied arguments and script content loaded from a local script file.
  • Microsoft.Resources/deploymentScripts/logs existing resource (child of myScript) representing the logs generated by the deployment script.

Security Findings

  • No security issues detected by MSDO scanners (Template Analyzer, Checkov, Trivy, Terrascan).
  • No hardcoded secrets, public endpoints, or overly permissive access patterns were observed in the templates or scripts.

Key Parameters

  • myBool (boolean): An example boolean input parameter to the deployment script.
  • myInt (integer): An example integer input parameter.
  • myString (string): An example string input parameter.
  • myArray (array): An example array input parameter.
  • myObject (object): An example object input parameter.

Notes for Reviewers

  • The sample cleanly demonstrates how to pass multiple complex input types to a deployment script and parse outputs and logs.
  • The original JSON ARM template (azuredeploy.json) was deleted, likely replaced by the main Bicep deployment file (main.bicep).
  • The metadata.json and README provide good context and documentation.
  • No security-sensitive patterns detected; script content is loaded from the relative path ./script.sh (not included in PR).
  • No significant missing documentation noticed.

Files Touched

  • main.bicep
  • metadata.json
  • README.md
  • Deleted: azuredeploy.json

Generated by the quickstart summarizer agent (v2 — agentic + MSDO security) · triggered by /validate

@ouldsid ouldsid merged commit 108253c into Azure:master May 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants