resolving review comments#42752
Merged
judyzhu10 merged 1 commit intoMay 6, 2026
Merged
Conversation
Next Steps to MergeImportant checks have failed. As of today they are not blocking this PR, but in near future they may.Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
judyzhu10
merged commit 7647a04
into
Azure:heenagupta/readerEndpointTypespec
48 of 53 checks passed
judyzhu10
pushed a commit
that referenced
this pull request
May 6, 2026
* swagger changes for reader endpoint * ran pretty * fix typos * resolving review comments (#42752) * Removing examples other than reader endpoint * Revert "Removing examples other than reader endpoint" This reverts commit 24f552a. --------- Co-authored-by: Heena Gupta <heenagupta@microsoft.com> Co-authored-by: Nitish Sharma <nitishsharma@microsoft.com>
judyzhu10
pushed a commit
that referenced
this pull request
May 22, 2026
* swagger changes for reader endpoint * ran pretty * fix typos * resolving review comments (#42752) * Removing examples other than reader endpoint * Revert "Removing examples other than reader endpoint" This reverts commit 24f552a. --------- Co-authored-by: Heena Gupta <heenagupta@microsoft.com> Co-authored-by: Nitish Sharma <nitishsharma@microsoft.com>
judyzhu10
pushed a commit
that referenced
this pull request
May 22, 2026
* swagger changes for reader endpoint * ran pretty * fix typos * resolving review comments (#42752) * Removing examples other than reader endpoint * Revert "Removing examples other than reader endpoint" This reverts commit 24f552a. --------- Co-authored-by: Heena Gupta <heenagupta@microsoft.com> Co-authored-by: Nitish Sharma <nitishsharma@microsoft.com>
mohitsinha-ms
added a commit
that referenced
this pull request
Jun 29, 2026
* copy example * change the version to 2025-12-01-preview * add 2025-12-01-preview version * Add FabricMirroringSettings API for MySQL FlexibleServers (#40348) Adds a new FabricMirroringSettings singleton proxy resource under MySQL FlexibleServers with GET, PUT (LRO), and List operations. Includes TypeSpec source, examples, and addresses all review comments. Co-authored-by: Mohit Sinha <mohitsinha@microsoft.com> * Swagger changes for reader endpoint (#42930) * swagger changes for reader endpoint * ran pretty * fix typos * resolving review comments (#42752) * Removing examples other than reader endpoint * Revert "Removing examples other than reader endpoint" This reverts commit 24f552a. --------- Co-authored-by: Heena Gupta <heenagupta@microsoft.com> Co-authored-by: Nitish Sharma <nitishsharma@microsoft.com> * add version control for readerendpoint models * feat: add rename server feature * add 20251201 in readme and generate openapi.json * add readme * fix reader endpoint example * fix: reader endpoint example * fix lint error * fix lint for fabircMirroring * fix lint for fabircMirroring * fix: api-version in source example ReaderEndpointCreate.json * fix: remove trailing space in main.tsp * fix rename server comment (#43336) Co-authored-by: Judy Zhu <zhujudy@microsoft.com> * Fabric Mirroring Review Fixes (#43298) * Fix singleton naming for FabricMirroringSettings * Remove deprecated 202 from FabricMirroringSettings PUT * Fix FabricMirroringSettings list to use paginated pattern * Fix FIXME suppression for FabricMirroringSettings no-delete * Regenerate OpenAPI for FabricMirroringSettings fixes * fix: align FabricMirroringSettings spec with live service behavior (#43335) * revert reader endpoint feature (#43424) Co-authored-by: Judy Zhu <zhujudy@microsoft.com> * fix: run tsp format on FabricMirroringSettings.tsp Agent-Logs-Url: https://github.com/Azure/azure-rest-api-specs/sessions/496ecd6a-047d-4ea0-8025-af94e4887590 Co-authored-by: judyzhu10 <22414761+judyzhu10@users.noreply.github.com> * fix comments * fix comments * fix comments * FabricMirroring: extend standard ResourceProvisioningState * Update ProvisioningStateMustBeReadOnly suppression reason * Scope ProvisioningStateMustBeReadOnly suppression with where clause * Fix ProvisioningStateMustBeReadOnly suppression: replace wildcard paths with explicit JSONPath expressions Co-authored-by: mohitsinha-ms <272738676+mohitsinha-ms@users.noreply.github.com> * Fix ProvisioningState suppression matching * Add where clause to ProvisioningState suppression --------- Co-authored-by: Judy Zhu <zhujudy@microsoft.com> Co-authored-by: tugupt <68744280+tugupt@users.noreply.github.com> Co-authored-by: Mohit Sinha <mohitsinha@microsoft.com> Co-authored-by: Rishabh Kumar <102506628+rishky1001@users.noreply.github.com> Co-authored-by: Heena Gupta <heenagupta@microsoft.com> Co-authored-by: Nitish Sharma <nitishsharma@microsoft.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: judyzhu10 <22414761+judyzhu10@users.noreply.github.com> Co-authored-by: mohitsinha-ms <272738676+mohitsinha-ms@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.