Skip to content

added dotnet specific ovverides for EKM clients#42793

Merged
hari9-9 merged 8 commits intomainfrom
kha/ekm-dotnet
May 6, 2026
Merged

added dotnet specific ovverides for EKM clients#42793
hari9-9 merged 8 commits intomainfrom
kha/ekm-dotnet

Conversation

@hari9-9
Copy link
Copy Markdown
Member

@hari9-9 hari9-9 commented Apr 30, 2026

SDK configuration pull request

Purpose of this PR

  • Added client's for EKM and marked them as internal for Dotnet SDK following the same pattern as other clients in the SDK

  • This would help autogenerate the SDK changes

  • [✅] Make changes to the SDK configuration only when there are no modifications to the API specification, eliminating the need for an ARM or Stewardship Board API review.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • [✅] I confirm this PR is modifying only SDK configurations, and not API related specifications.
  • [✅] I have reviewed and used the respective tspconfig.yaml templates:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2026

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added data-plane TypeSpec Authored with TypeSpec labels Apr 30, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec KeyVault
Python azure-keyvault-administration
JavaScript @azure/keyvault-admin

Comment generated by After APIView workflow run.

@mikeharder
Copy link
Copy Markdown
Member

i think avocado failure is because the check requires case-sensitive readme.md. you have a different casing README.md. create a new PR to main, just renaming your readme.md to the correct casing. i can approve that PR if needed.

@hari9-9
Copy link
Copy Markdown
Member Author

hari9-9 commented May 5, 2026

Added avacado approved label as there exist a bug tracking the issue of avacado failures while transition from non-date based api version to date-based api version.

Azure/avocado#159

@hari9-9 hari9-9 marked this pull request as ready for review May 5, 2026 16:12
@hari9-9 hari9-9 requested review from a team and heaths as code owners May 5, 2026 16:12
@hari9-9 hari9-9 added PublishToCustomers Acknowledgement the changes will be published to Azure customers. Approved-Suppression labels May 5, 2026
@hari9-9
Copy link
Copy Markdown
Member Author

hari9-9 commented May 6, 2026

Added Approved Suppression as we dont have Suppression review for DP Changes as Per: #37987

@hari9-9 hari9-9 merged commit 0aea5f5 into main May 6, 2026
105 of 108 checks passed
@hari9-9 hari9-9 deleted the kha/ekm-dotnet branch May 6, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado Approved-Suppression data-plane KeyVault PublishToCustomers Acknowledgement the changes will be published to Azure customers. SuppressionReviewRequired TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants