Skip to content

mgmt, Java, Validate TypeSpec conversion for ApiCenter service converted tsp#43291

Closed
v-huizhu2 wants to merge 10 commits into
Azure:mainfrom
v-huizhu2:java_mgmt_apicenter_2026051801
Closed

mgmt, Java, Validate TypeSpec conversion for ApiCenter service converted tsp#43291
v-huizhu2 wants to merge 10 commits into
Azure:mainfrom
v-huizhu2:java_mgmt_apicenter_2026051801

Conversation

@v-huizhu2

Copy link
Copy Markdown
Member

SDK configuration pull request

Azure/azure-sdk-for-java#49099

Purpose of this PR

  • Make changes to the SDK configuration only when there are no modifications to the API specification, eliminating the need for an ARM or Stewardship Board API review.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Getting help

  • First, carefully read through this PR description, from top to bottom. Fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the VersioningReviewRequired label.
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.


Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added the TypeSpec Authored with TypeSpec label May 18, 2026
@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.ApiCenter
Java com.azure.resourcemanager:azure-resourcemanager-apicenter
Swagger Microsoft.ApiCenter
Go sdk/resourcemanager/apicenter/armapicenter
Python azure-mgmt-apicenter

Comment generated by After APIView workflow run.

@v-huizhu2 v-huizhu2 marked this pull request as ready for review May 18, 2026 07:17
@github-actions github-actions Bot added ARMReview resource-manager RPaaS WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 18, 2026
Comment thread specification/apicenter/ApiCenter.Management/client.tsp Outdated
@github-actions github-actions Bot removed NotReadyForARMReview resource-manager ARMReview RPaaS VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels May 18, 2026
@github-actions github-actions Bot added ARMReview resource-manager RPaaS WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMAutoSignedOff-IncrementalTSP ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 18, 2026
@weidongxu-microsoft weidongxu-microsoft dismissed their stale review May 19, 2026 03:40

no, you haven't fixed the typespec -- there is diff on generated swagger

@github-actions github-actions Bot added VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required NotReadyForARMReview and removed ARMAutoSignedOff-IncrementalTSP ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels May 19, 2026
@v-huizhu2 v-huizhu2 closed this May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview NotReadyForARMReview resource-manager RPaaS TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants