Skip to content

[Storage]Fix the .net SDK PR #59068 review comments. #43371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
live1206 merged 14 commits into from
May 21, 2026
Merged

[Storage]Fix the .net SDK PR #59068 review comments. #43371

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
55a07d0
Fix the .net SDK PR #59068 review comments.
blueww May 20, 2026
015ce0e
Fix the validation failure
blueww May 20, 2026
dc3850a
formatted
welovej May 20, 2026
bd95c28
Merge remote-tracking branch 'upstream/main' into pr/43371
welovej May 20, 2026
844d555
Revert "Merge remote-tracking branch 'upstream/main' into pr/43371"
welovej May 20, 2026
ffd35cb
Reapply "Merge remote-tracking branch 'upstream/main' into pr/43371"
welovej May 20, 2026
9252437
Update client.tsp
welovej May 20, 2026
c2d52b2
Update client.tsp
welovej May 20, 2026
46001c2
Update client.tsp
welovej May 20, 2026
7f7bb63
Update client.tsp
welovej May 20, 2026
a573464
revert the type change which don't need.
blueww May 20, 2026
a9af194
Fix Storage management C# review customizations
welovej May 20, 2026
3945760
Merge branch 'netSDKfix' of https://github.com/blueww/azure-rest-api-…
welovej May 21, 2026
e99d966
update
welovej May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 57 additions & 2 deletions specification/storage/Storage.Management/client.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,14 @@ using Microsoft.Storage;
@@clientName(LeaseShareRequest, "LeaseShareContent", "csharp");
@@clientName(ListAccountSasResponse, "GetAccountSasResult", "csharp");
@@clientName(ListServiceSasResponse, "GetServiceSasResult", "csharp");
@@clientName(TestConnectionResponse, "TestConnectionResult", "csharp");
@@clientName(
TestConnectionResponse,
"StorageConnectorTestConnectionResult",
"csharp"
);
@@clientName(
TestExistingConnectionRequest,
"TestExistingConnectionContent",
"StorageConnectorTestExistingConnectionContent",
"csharp"
);
@@clientName(
Expand Down Expand Up @@ -814,6 +818,57 @@ namespace Azure.ResourceManager.Models {
"IsPriorityReplicationEnabled",
"csharp"
);
@@clientName(
ObjectReplicationPolicyPropertiesTagsReplication.enabled,
"IsTagsReplicationEnabled",
"csharp"
);

// Native data sharing patch model naming
@@clientName(TrackedResourceUpdate, "StorageTrackedResourcePatch", "csharp");
@@clientName(
StorageConnectorAuthPropertiesUpdate,
"StorageConnectorAuthPropertiesPatch",
"csharp"
);
@@clientName(
StorageConnectorSourceUpdate,
"StorageConnectorSourcePatch",
"csharp"
);
@@clientName(DataShareSourceUpdate, "DataShareSourcePatch", "csharp");
@@clientName(
ManagedIdentityAuthProperties,
"StorageConnectorManagedIdentityAuth",
"csharp"
);
@@clientName(
ManagedIdentityAuthPropertiesUpdate,
"StorageConnectorManagedIdentityAuthPatch",
"csharp"
);
@@clientName(
StorageConnectorPropertiesUpdate,
"StorageConnectorPropertiesPatch",
"csharp"
);
@@clientName(
StorageDataSharePropertiesUpdate,
"StorageDataSharePropertiesPatch",
"csharp"
);

// Native data sharing property renames/types
@@clientName(
StorageConnectorProperties.testConnection,
"ShouldTestConnection",
"csharp"
);
@@clientName(
StorageConnectorPropertiesUpdate.testConnection,
"ShouldTestConnection",
"csharp"
);

// LocalUser property renames
@@clientName(
Expand Down