Skip to content

Update DevCenter to use CustomerManagedKeyEncryptionV4 from Foundations#44086

Open
markcowl wants to merge 1 commit into
typespec-nextfrom
fix/use-cmk-v4-types
Open

Update DevCenter to use CustomerManagedKeyEncryptionV4 from Foundations#44086
markcowl wants to merge 1 commit into
typespec-nextfrom
fix/use-cmk-v4-types

Conversation

@markcowl

Copy link
Copy Markdown
Member

Summary

Replace direct usage of internal \CommonTypes.CustomerManagedKeyEncryption\ with \Azure.ResourceManager.Foundations.CustomerManagedKeyEncryptionV4\ in the DevCenter spec.

Changes

  • models.tsp: Changed \CustomerManagedKeyEncryption\ property type to \CustomerManagedKeyEncryptionV4\
  • client.tsp: Updated @@clientName\ target to use V4 type
  • back-compatible.tsp: Added @@clientName\ to strip V4 suffix for OpenAPI compatibility
  • package.json: Updated dependencies to use pkg-pr-new packages from typespec-azure PR

Dependencies

Notes

  • OpenAPI regeneration will be completed once the updated pkg-pr-new packages are available from the dependent PR
  • Only DevCenter is impacted; Maps spec uses \CommonTypes.Encryption\ (still public) and needs no changes

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Summarize PR Impact has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Important checks have failed. As of today they are not blocking this PR, but in near future they may.
Addressing the following failures is highly recommended:
  • ⚠️ The check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.


Comment generated by summarize-checks workflow run.

@markcowl markcowl force-pushed the fix/use-cmk-v4-types branch 3 times, most recently from 65a20ae to 3e249b4 Compare June 18, 2026 19:44
Comment thread specification/devcenter/DevCenter.Management/back-compatible.tsp Outdated
Comment thread specification/devcenter/DevCenter.Management/back-compatible.tsp
@markcowl markcowl force-pushed the fix/use-cmk-v4-types branch 3 times, most recently from 2ff0aa0 to bcab701 Compare June 18, 2026 21:50
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/devcenter/armdevcenter
Java com.azure.resourcemanager:azure-resourcemanager-maps
Java com.azure.resourcemanager:azure-resourcemanager-devcenter
Python azure-mgmt-maps
Python azure-mgmt-devcenter
JavaScript @azure/arm-devcenter
TypeSpec Microsoft.DevCenter
TypeSpec Microsoft.Maps

Comment generated by After APIView workflow run.

@markcowl markcowl force-pushed the fix/use-cmk-v4-types branch from bcab701 to f0d2268 Compare June 18, 2026 23:19
…inition

The @armCommonDefinition decorators for CustomerManagedKeyEncryption and
Encryption types have been removed in the typespec-azure-resource-manager
package. Add clientName decorators to strip namespace qualification from
emitted type names. Rename local DevCenter KeyEncryptionKeyIdentity model
to KeyEncryptionKeyIdentityUpdate to avoid name clash.

Depends on: Azure/typespec-azure#4627

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@markcowl markcowl force-pushed the fix/use-cmk-v4-types branch from f0d2268 to a8497f1 Compare June 18, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant