Skip to content

Regenerate OpenAPI for DevCenter and Maps after removing armCommonDefinition#44092

Open
markcowl wants to merge 4 commits into
mainfrom
fix/use-cmk-v4-types-main
Open

Regenerate OpenAPI for DevCenter and Maps after removing armCommonDefinition#44092
markcowl wants to merge 4 commits into
mainfrom
fix/use-cmk-v4-types-main

Conversation

@markcowl

Copy link
Copy Markdown
Member

Summary

The @armCommonDefinition decorators for CustomerManagedKeyEncryption and Encryption types have been removed in the typespec-azure-resource-manager package. This causes these types to be emitted inline rather than as common-types \\ entries.

Changes

  • DevCenter back-compatible.tsp: Added @@clientName\ to strip namespace qualification from emitted types
  • DevCenter models.tsp: Renamed local \KeyEncryptionKeyIdentity\ to \KeyEncryptionKeyIdentityUpdate\ to avoid name clash
  • DevCenter client.tsp: Updated reference to renamed model
  • Maps back-compatible.tsp: Added @@clientName\ to strip namespace qualification
  • OpenAPI regenerated for DevCenter (3 versions) and Maps (1 version)
  • package.json: Updated dependencies to use pkg-pr-new packages from typespec-azure PR

Dependencies

…inition

The @armCommonDefinition decorators for CustomerManagedKeyEncryption and
Encryption types have been removed in the typespec-azure-resource-manager
package. Add clientName decorators to strip namespace qualification from
emitted type names. Rename local DevCenter KeyEncryptionKeyIdentity model
to KeyEncryptionKeyIdentityUpdate to avoid name clash.

Depends on: Azure/typespec-azure#4627

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the VersioningReviewRequired label.
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.


Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added ARMReview resource-manager RPaaS TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jun 19, 2026
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.DevCenter
Swagger Microsoft.Maps-Maps
TypeSpec Microsoft.DevCenter
TypeSpec Microsoft.Maps
Go sdk/resourcemanager/devcenter/armdevcenter
JavaScript @azure/arm-devcenter
Python azure-mgmt-maps
Python azure-mgmt-devcenter
Java com.azure.resourcemanager:azure-resourcemanager-maps
Java com.azure.resourcemanager:azure-resourcemanager-devcenter
C# Azure.ResourceManager.Maps

Comment generated by After APIView workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview Maps NotReadyForARMReview resource-manager RPaaS TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant