refactor(toolbox): simplify tool type definitions and update model re…#44112
Open
glecaros wants to merge 2 commits into
Open
refactor(toolbox): simplify tool type definitions and update model re…#44112glecaros wants to merge 2 commits into
glecaros wants to merge 2 commits into
Conversation
glecaros
requested review from
balapv,
dargilco,
johanste,
qubitron and
trrwilson
as code owners
Next Steps to MergeImportant checks have failed. As of today they are not blocking this PR, but in near future they may.Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
viswabalaji
approved these changes
Jun 19, 2026
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
dargilco
reviewed
Jun 19, 2026
| fabric_iq_preview: ToolboxFabricIQPreviewToolType, | ||
| toolbox_search_preview: ToolboxSearchPreviewToolType, | ||
| string, | ||
| code_interpreter: "code_interpreter", |
Member
There was a problem hiding this comment.
Can't we re-use the string value defined for tool type?
Member
There was a problem hiding this comment.
Use ToolType.code_interpreter instead of "code_interpreter"?
Member
Author
There was a problem hiding this comment.
that does not really work as ToolType.code_interpreter is not technically a string but rather a UnionVariant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ferences
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.